Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adb40 #110

Merged
merged 2 commits into from May 3, 2019

Conversation

Projects
None yet
5 participants
@codeskyblue
Copy link
Member

commented Apr 17, 2019

No description provided.

@codeskyblue

This comment has been minimized.

Copy link
Member Author

commented Apr 17, 2019

@esmiralha

This comment has been minimized.

Copy link

commented Apr 22, 2019

Is this PR merged yet?

@thinkhy thinkhy requested review from sorccu and thinkhy Apr 23, 2019

@thinkhy

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

I've tested this PR for adb 1.0.40 latest version, it works well.
@sorccu the bug will cause STF provider crash when use adb latest version to connect adbkit tcp bridge, we need to merge this PR ...

@codeskyblue

This comment has been minimized.

Copy link
Member Author

commented Apr 25, 2019

I publish another lib to npm named adbkit2, installed by npm i adbkit2 for hotfix.

@sorccu

This comment has been minimized.

Copy link
Member

commented Apr 25, 2019

Guys, you need to be more patient. Even if it’s a relatively large issue, paid work takes priority. I’ll try to get this merged and released sometime soon.

@codeskyblue

This comment has been minimized.

Copy link
Member Author

commented Apr 30, 2019

@sorccu when will you be free?

@sorccu sorccu merged commit 57546a0 into openstf:master May 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.