Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Thanks extension to Wiki (incl. Echo extension as dependency) #214

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@Tigerfell
Copy link
Contributor

commented Jan 24, 2019

This is an attempt to fix openstreetmap/operations#265. This should install the MediaWiki extensions "Echo" and "Thanks" to the wikis.
AFAIK we need version 1.31 of "Echo" because the current master requires MediaWiki >= 1.32.0 and we just run 1.31.1. This can be obtained from MediaWiki itself: https://www.mediawiki.org/wiki/Special:ExtensionDistributor/Thanks (possibly also from their repos).
Please let me know if there is anything wrong with this PR. I will try to fix it.

@tomhughes

This comment has been minimized.

Copy link
Member

commented Jan 24, 2019

Well that won't do anything - that just adds templates for the configuration but it never actually uses them and certainly doesn't install the extensions.

Firstly those should probably be in the wiki cookbook (unless we're going to install this on the other board and DWG wikis as well) and then you need something like https://github.com/openstreetmap/chef/blob/master/cookbooks/wiki/recipes/default.rb#L59 to actually make use of them.

Note that this will only work if they can be installed from the mediawiki github, and if they need to be composed then you need to make sure you enable that when declaring the resource.

@Tigerfell

This comment has been minimized.

Copy link
Contributor Author

commented Jan 25, 2019

Thank you. I am not sure about getting the correct version of the extension in line 90 of default.rb: ee53e17#diff-ac5c688c80c445c09307df062b225ab6R90

PS: I will merge the commits once this is solved.

@tomhughes

This comment has been minimized.

Copy link
Member

commented Jan 25, 2019

There shouldn't be any reason to specify a version - by default we will track the REL1_31 branch in the github repo (or equivalent based on the current MW version).

@Tigerfell

This comment has been minimized.

Copy link
Contributor Author

commented Jan 26, 2019

Great, I updated and squashed it. Anything else that needs to be changed?

@tomhughes tomhughes closed this in ceab552 Jan 26, 2019

@tomhughes

This comment has been minimized.

Copy link
Member

commented Jan 26, 2019

They don't actually need composing (there are no run time dependencies in composer.json) so I removed that.

@Tigerfell

This comment has been minimized.

Copy link
Contributor Author

commented Jan 26, 2019

I was not really sure about it, so I added it just in case.
Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.