Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to save changes #1782

Closed
ghost opened this issue Sep 4, 2013 · 23 comments
Closed

Unable to save changes #1782

ghost opened this issue Sep 4, 2013 · 23 comments

Comments

@ghost
Copy link

ghost commented Sep 4, 2013

The following text shows up on trying to save any changes:

An error occurred while trying to save.

This problem is seen using Firefox 23 and Chrome 29.

@jfirebaugh
Copy link
Member

Since saving works for the vast majority of users, we'll need more details in order to track this down. Does this happen for you with any change, anywhere in the world, at any time? Or just one or two changes? Or changes in a specific area? Or specific types of changes? Does it happen in Chrome's incognito mode? Are there any errors in the javascript console when it occurs?

@ghost
Copy link
Author

ghost commented Sep 4, 2013

I have tried to save nodes, add ways, add highway and bridge tags over the past week (that was the first time I had used iD) without success. Such attempts were made in India and London. Finally I had to resort to JOSM for saving the edits. Chrome's Incognito Mode also doesn't allow me to save changes. Also, I tried interchanging my internet connection from WLAN to LAN, with the same effect. The following error shows up in the JavaScript Console in Chrome upon clicking the "Save" button:

error

PUT http://www.openstreetmap.org/api/0.6/changeset/create iD-76693a407d63fde8863e42f95f775557.js:13 a.rawxhr iD-76693a407d63fde8863e42f95f775557.js:13 a.xhr iD-76693a407d63fde8863e42f95f775557.js:13 u iD-76693a407d63fde8863e42f95f775557.js:13 r.xhr iD-76693a407d63fde8863e42f95f775557.js:13 d.putChangeset iD-76693a407d63fde8863e42f95f775557.js:68 s iD-76693a407d63fde8863e42f95f775557.js:68 t iD-76693a407d63fde8863e42f95f775557.js:1 (anonymous function) iD-76693a407d63fde8863e42f95f775557.js:70 (anonymous function) iD-76693a407d63fde8863e42f95f775557.js:1

@jfirebaugh
Copy link
Member

Thanks, the error is an interesting data point. Can you try on http://openstreetmap.us/iD/master/ and post the error there, if you get one?

@ghost
Copy link
Author

ghost commented Sep 5, 2013

This is what I get after testing iD there:

error2

PUT http://www.openstreetmap.org/api/0.6/changeset/create iD.js:11510
ohauth.rawxhr iD.js:11510
ohauth.xhr iD.js:11518
run iD.js:11227
oauth.xhr iD.js:11214
connection.putChangeset iD.js:19761
save iD.js:18860
event iD.js:667
(anonymous function) iD.js:24450
(anonymous function) iD.js:1532
(anonymous function) raven.min.js:2

@manudparakkal
Copy link

i also have the same problem madnag4u help me if u could get out of it

@ghost
Copy link
Author

ghost commented Oct 4, 2013

error3

This is the error I get when I ran iD today on Chrome (Version 29.0.1547.76 m) Incognito Mode. I have highlighted the changes from my previous comment. I have AdBlock and many other extensions installed, but I expect all of them to be disabled in the Incognito Mode. And as I mentioned previously, changesets are successfully uploaded from JOSM and Potlatch2.

PUT http://www.openstreetmap.org/api/0.6/changeset/create ____ openstreetmap.us/iD/master/:1
PUT http://www.openstreetmap.org/api/0.6/changeset/create ____ iD.js:11510
ohauth.rawxhr _____________________________ iD.js:11510
ohauth.xhr ________________________________ iD.js:11518
run ______________________________________ iD.js:11227
oauth.xhr _________________________________ iD.js:11214
connection.putChangeset ____________________ iD.js:20151
save _____________________________________ iD.js:19216
event ____________________________________ iD.js:667
(anonymous function) _______________________ iD.js:24875
(anonymous function) _______________________ iD.js:1532
(anonymous function) _______________________ raven.js:1326

@manudparakkal
Copy link

Failed to load resource http://www.openstreetmap.org/api/0.6/changeset/create
Failed to load resource http://www.openstreetmap.org/api/0.6/changeset/create
Failed to load resource http://www.openstreetmap.org/api/0.6/changeset/create
Failed to load resource http://www.openstreetmap.org/api/0.6/changeset/create
Failed to load resource http://www.openstreetmap.org/api/0.6/changeset/create

this is what i got while trying to save the map by clicking on the left side

@jfirebaugh
Copy link
Member

Can you pass on any information about the failed request from the "Network" pane in the developer tools? Do this:

image

And then gist the resulting file. Thanks!

@ghost
Copy link
Author

ghost commented Oct 10, 2013

Here's the gist of the HAR file you requested:

https://gist.github.com/madnag4u/6913128#file-openstreetmap-us-har

@jfirebaugh
Copy link
Member

@madnag4u There aren't any failed requests in that log. Are you sure that was from a session where saving failed?

@tyrasd
Copy link
Member

tyrasd commented Oct 11, 2013

@jfirebaugh Actually, it looks like as if the changeset/create PUT request responds with a 200, but doesn't return its payload (the changeset's id). How can that happen?

@jfirebaugh
Copy link
Member

Yeah, you're right. Content length is 8, body is an empty string.

So this look like either a bug in the API or a network problem (bad cache/proxy/firewall). The API would return an empty body if cs.id was nil, but that seems unlikely.

@madnag4u Is there anything unusual about your network setup? For example are you running any firewall or filtering software, or connecting through a proxy?

@jfirebaugh
Copy link
Member

@madnag4u @manudparakkal Ping?

@ghost
Copy link
Author

ghost commented Oct 24, 2013

Sorry for the late reply. My city was badly hit by the cyclone Phailin, thus communication infrastructure was down.

I use Kaspersky anti virus program. No other firewalls or filtering software were used. No proxies were used either.

@ghost
Copy link
Author

ghost commented Nov 8, 2013

Hmmm. This looks like a network problem. The other day, I tried editing something in iD in another city. It showed no issues and the changeset was saved without a hitch. I guess I can't use iD from home :'(

@jfirebaugh
Copy link
Member

Yes, I suspect a network problem too. Only counter evidence is that somehow Potlatch and JOSM apparently get valid responses from the same API.

@pnorman
Copy link
Contributor

pnorman commented Nov 22, 2013

@jfirebaugh Actually, it looks like as if the changeset/create PUT request responds with a 200, but doesn't return its payload (the changeset's id). How can that happen?

@Firefishy, did we see this with one of the people having problems from Australia?

@manudparakkal
Copy link

because of this i have stopped marking roads and other data

On Fri, Nov 22, 2013 at 5:37 AM, John Firebaugh notifications@github.comwrote:

Yes, I suspect a network problem too. Only counter evidence is that
somehow Potlatch and JOSM apparently get valid responses from the same API.


Reply to this email directly or view it on GitHubhttps://github.com//issues/1782#issuecomment-29037635
.

MANU D PARAKKAL
PARAKKAL BUILDINGS
ALWAYE
9447029905

@ghost
Copy link
Author

ghost commented Nov 24, 2013

Today I tried saving my changes using FF 25.0.1 in Windows; still no luck. However, saving was successful with the firewall disabled.

@Firefishy
Copy link
Member

@madnag4u 1) What type of firewall do you use? 2) Do you know if your firewall blocks ICMP? 3) Do you know what your network's maximum MTU is?

@ghost
Copy link
Author

ghost commented Nov 27, 2013

I use Kaspersky Internet Security 2012. The firewall comes bundled with it. I use no other firewalls that I know of.

In my previous comment, I thought that I had disabled only the firewall. In actuality, I had disabled all the Protection Components of Kaspersky Internet Security (KIS). After @Firefishy asked me to check, I found out that it was not the Firewall component of KIS causing trouble, it was the IM Anti-virus component.

Basically, by disabling just the IM Anti-virus component of KIS 2012 (and keeping all other components active), I was able to save changes through iD.

@Firefishy
Copy link
Member

@manudparakkal Any chance you have a similar Firewall or Security product installed and enabled?

@jfirebaugh
Copy link
Member

This is a network or AV software issue that's not going to be possible to fix in iD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants