Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash in Chrome #2295

Closed
Stalfur opened this issue Jul 20, 2014 · 19 comments
Closed

Crash in Chrome #2295

Stalfur opened this issue Jul 20, 2014 · 19 comments

Comments

@Stalfur
Copy link
Contributor

Stalfur commented Jul 20, 2014

Yesterday I noticed I started to be unable to load certain areas in iD. I finally managed to get a javascript error out of it.

To do so I had to first start a browser and javascript console, then go to the place in question. Then the iD editor loads (error2 image) but I'm unable to drag anything, I can however change attributes of nodes. Without the console open I get the crash message (error1 image).

My version is Version 36.0.1985.125 m (up to date) on Windows 7 64 bit.

error1
error2

@jfirebaugh
Copy link
Member

I fixed the nodeValue deprecation messages in 4994566. I don't think they are related to the crash or being unable to drag though.

@lorenzoguidotti
Copy link

I too have the same problem.

@sabas
Copy link
Contributor

sabas commented Jul 22, 2014

Same here, same problem and system as @Stalfur
The warning -although imho unrelated- appears at

iD-9270de8864c63c257137f38c2bd24eb8.js:8

@Stalfur
Copy link
Contributor Author

Stalfur commented Jul 23, 2014

iD currently unusable in Chrome on Windows 7 due to this crash. iD in Firefox works.

@sabas
Copy link
Contributor

sabas commented Jul 23, 2014

Funny, on Ubuntu Gnome 14.04, Chrome v 36.0.1985.125, apart from the warning it works normally....

@jfirebaugh
Copy link
Member

I've filed a chromium bug: https://code.google.com/p/chromium/issues/detail?id=396725 (currently "Restricted" status, so you probably won't be able to see it).

@jfirebaugh jfirebaugh changed the title Crash in Chrome : 'Attr.nodeValue' is deprecated. Please use 'value' instead. Crash in Chrome Jul 23, 2014
@talllguy
Copy link

I'm able to repeat the crash in Chrome / Win 7 by editing someplace, and then rapidly zooming out to z14 or less, when the map stops being editable. This always seems to send chrome crashing.

Interestingly, the behavior post crash (after a reload) is similar to the one I've experienced in #2151, where it is no longer possible to drag nodes around. So they could be related.

@jfirebaugh
Copy link
Member

The bug I reported was marked as a duplicate of https://code.google.com/p/chromium/issues/detail?id=343458

@bhousel
Copy link
Member

bhousel commented Jul 24, 2014

In context.enter:
is it possible for enter events to dispatch before exit events?

    context.enter = function(newMode) {
        if (mode) {
            mode.exit();
            dispatch.exit(mode);
        }

        mode = newMode;
        mode.enter();
        dispatch.enter(mode);
    };

@marczoutendijk
Copy link

To be complete:
The same error appears on Mac OS X (10.9.4) with Chrome. Safari is OK.

@jfirebaugh
Copy link
Member

Please try editing at http://openstreetmap.us/iD/master/ and see if the crashes still occur.

@Stalfur
Copy link
Contributor Author

Stalfur commented Jul 24, 2014

I've tried it out by dragging nodes around and merging them and separating them. Seems to work fine so far!
Are the lan & lon values supposed to be switched on the master?
http://openstreetmap.us/iD/master/#background=Bing&map=15.60/25.1241/-17.8148
vs the URL in my first post

@SomeoneElseOSM
Copy link

For info, there's also a user report of what works and what doesn't here:

https://help.openstreetmap.org/questions/35118/edit-with-id-in-browser-editor-not-working

(and in a very limited test using Chrome Version 36.0.1985.125 m on Windows 7, the main OSM site worked for me too, but I didn't try anything drastic)

@marczoutendijk
Copy link

In my case the crashing errors I experienced (always during zoom actions) dissappeared indeed by trying out the testversion!

@marczoutendijk
Copy link

Exactly what will happen next? It seems that there is a solution (or at least a workaround).
When will the regular ID editor be updated with said fix?

@jfirebaugh
Copy link
Member

I'll make a release today.

@valleyofdawn
Copy link

I'm also suffering from instability in Chrome for windows in the last 10 days.
It only happens when the Strava slide module is turned on and when I zoom in or drag the map around.

@jfirebaugh
Copy link
Member

The workaround seems to be working well, and the upstream bug is now fixed in the latest Chrome canary.

@valleyofdawn The Strava deployment of iD likely does not contain the workaround -- @paulmach can you update?

@paulmach
Copy link
Contributor

Sweet, someone else is actually using slide. Would love your feedback.

Rebased and updated to latest commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants