Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map notes #2629

Closed
xamanu opened this issue May 3, 2015 · 14 comments
Closed

Map notes #2629

xamanu opened this issue May 3, 2015 · 14 comments
Assignees
Labels
new-feature A new feature for iD priority A top priority issue that has a big impact or matter most to new mappers

Comments

@xamanu
Copy link

xamanu commented May 3, 2015

Hello,

thank you so much for this editor! It is a huge help when training people for the first time for OpenStreetMap, and this is so important.

One thing which is really missing, in order to get people into mapping, and to have a complete mapping workflow, is a map notes (https://wiki.openstreetmap.org/wiki/Notes) integration as there is for JOSM (https://wiki.openstreetmap.org/wiki/JOSM/Plugins/Notes).

Thank you.

@bhousel
Copy link
Member

bhousel commented May 3, 2015

Thanks, glad you like the editor! Some work started on adding an OSM notes layer a while ago (see #1895), but it's pretty much stalled. I agree we should finish it up and make this a priority.

@konfiot
Copy link

konfiot commented Aug 26, 2015

I agree, that would be much easier

@brycenesbitt
Copy link
Contributor

+1 on map notes. I'm working with a group that is using iD, and creating certain map notes at the same time. It's a barrier to understanding that they have to write down the node number, flip to the OSM home page, enter the node number, find the place, create a map note.

Just as important is an interface allowing a new mapper to see a note in their area, research it, and close it.

@xamanu
Copy link
Author

xamanu commented Apr 26, 2016

I was just conducting two workshops for people from rural areas in Kyrgyzstan. They had no big computer experience. The first workshop we did with JOSM and it was very hard for them to get into it. The second one we did using iD, which was a lot better, but the only big missing issue was map notes support. Surveying data with map notes, on the other side, seems just to be the perfect workflow.

@boothym
Copy link
Contributor

boothym commented Jun 23, 2016

At the very least could we get an icon within iD showing the location of a note? Sometimes you click edit and want to know exactly where a note was placed, especially if it's a busy area of the map.

I do usually middle click the edit button to open iD in a new tab, but even then it's not always easy to figure out where the note is.

@bhousel bhousel added new-feature A new feature for iD and removed enhancement labels Nov 1, 2016
@bhousel bhousel added the priority A top priority issue that has a big impact or matter most to new mappers label Mar 22, 2017
@homersimpsons
Copy link
Contributor

@boothym when you are in the note : openstreetmap.org/note/xxxx this one is centered in the map (no map= part in the URL) so when you edit it with iD the note remain centered, you can start zooming using the '+' button to hold the center.

@bhousel bhousel added this to Other Priorities in Priorities Jul 6, 2017
@avanc
Copy link

avanc commented Apr 25, 2018

Is this feature not on the development roadmap anymore?
There are a lot of notes in my area by another user:
https://www.openstreetmap.org/#map=13/52.3784/10.0784&layers=N

The approach of @homersimpsons is a lot of overhead for so many notes.

@thomas-hervey
Copy link
Collaborator

@avanc I will be working on this feature this summer as a Google Summer of Code project with the supervision of @bhousel. I can keep you in the loop with my progress and welcome any suggestions.

@avanc
Copy link

avanc commented Apr 25, 2018

@thomas-hervey Great to hear that development of this feature continues. Let me know when you need a beta tester.

@thomas-hervey
Copy link
Collaborator

Hello again everyone. @bhousel and I have been discussing the UI a bit for the new notes feature. We likely don't want to add a 'add note' button to the top toolbar, but it may still need to be a mode, much like editing points, lines, areas. I've considered adding it to the bottom of the menu-controls list (like is is on osm.org). Thoughts?

@homersimpsons
Copy link
Contributor

All like the osm.org website, in the right side bar, seems good to me (select whether or not the notes should be shown, add note). If it's possible show the active note (even if note layer is disabled, just like osm.org)

@matkoniecz
Copy link
Contributor

Right side bar sounds better than putting it next to node/way/area that would suggest it is part of map data.

@thomas-hervey
Copy link
Collaborator

Hello everyone,
So I have made some progress on the notes, but I ran into a few snags displaying them. Therefore, I cloned a new copy of iD (which has solved some other issues), and I will be committing small steps from now on. Check out the notes branch.

@bhousel bhousel added the wip Work in progress label Jun 24, 2018
@bhousel bhousel removed the wip Work in progress label Jul 26, 2018
@bhousel
Copy link
Member

bhousel commented Jul 26, 2018

This was done in #5107 and #5162 🎉

@bhousel bhousel removed this from Other Priorities in Priorities Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature A new feature for iD priority A top priority issue that has a big impact or matter most to new mappers
Projects
None yet
Development

No branches or pull requests

10 participants