Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop rendering amenity=swimming_pool? #2926

Closed
matthijsmelissen opened this issue Jan 23, 2016 · 3 comments
Closed

Stop rendering amenity=swimming_pool? #2926

matthijsmelissen opened this issue Jan 23, 2016 · 3 comments

Comments

@matthijsmelissen
Copy link

The tag leisure=swimming_pool is about 11 times as popular as amenity=swimming_pool. In addition, a proposal to discourage amenity=swimming_pool has been accepted with an overwhelming majority. The tag amenity=swimming_pool is now marked as discouraged on the wiki.

iD (correctly) proposes the tag leisure=swimming_pool when searching for 'Swimming pool'. However, iD still displays a swimming pool icon for objects with the tag amenity=swimming_pool.

What do you think is best? Keep rendering the icon for discouraged tag because it is still in common use, or drop the icon in the hope that this will speed up the unification of the tags?

@matthijsmelissen
Copy link
Author

Some additional information: iD is the only of the big projects that does anything with amenity=swimming_pool. The tag is not rendered by openstreetmap-carto or OsmAnd, nor treated special in any way by JOSM.

@bhousel
Copy link
Member

bhousel commented Jan 23, 2016

What do you think is best? Keep rendering the icon for discouraged tag because it is still in common use, or drop the icon in the hope that this will speed up the unification of the tags?

We keep presets for deprecated tags that are in common use, but we mark them as unsearchable so users can not pick them.

current stats on taginfo:

count tag
521 789 leisure=swimming_pool
45 746 amenity=swimming_pool

Tags do not magically change when editors prefer new tags over old ones. If people want the tag to be changed, somebody needs to do the work of changing it. Discussion on the tagging mailing list, and editing the osm wiki are not going to change the tags.

@bhousel bhousel closed this as completed Jan 23, 2016
@matthijsmelissen
Copy link
Author

Thanks for explaining the rationale!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants