Error preventing modals from getting removed #305

Closed
samanpwbb opened this Issue Dec 19, 2012 · 6 comments

Comments

Projects
None yet
2 participants
@samanpwbb
Member

samanpwbb commented Dec 19, 2012

I get: Uncaught TypeError: Object #<HTMLDivElement> has no method 'remove when I click outside a modal, and nothing happens. I assume this should be closing the modal.

@tmcw

This comment has been minimized.

Show comment Hide comment
@tmcw

tmcw Dec 21, 2012

Contributor

Which modals? I'm not getting this error currently.

Contributor

tmcw commented Dec 21, 2012

Which modals? I'm not getting this error currently.

@samanpwbb

This comment has been minimized.

Show comment Hide comment
@samanpwbb

samanpwbb Dec 21, 2012

Member

it's impossible for me to close the inspector modal. All modals should close with 'ESC' or by clicking anywhere off the modal.

Member

samanpwbb commented Dec 21, 2012

it's impossible for me to close the inspector modal. All modals should close with 'ESC' or by clicking anywhere off the modal.

@tmcw

This comment has been minimized.

Show comment Hide comment
@tmcw

tmcw Dec 21, 2012

Contributor

it's impossible for me to close the inspector modal.

The details pane that slides down, the non-collapsed version, or the reference modal?

Contributor

tmcw commented Dec 21, 2012

it's impossible for me to close the inspector modal.

The details pane that slides down, the non-collapsed version, or the reference modal?

@samanpwbb

This comment has been minimized.

Show comment Hide comment
@samanpwbb

samanpwbb Dec 21, 2012

Member
@tmcw

This comment has been minimized.

Show comment Hide comment
@tmcw

tmcw Dec 21, 2012

Contributor

Okay, this is Safari-specific.

Contributor

tmcw commented Dec 21, 2012

Okay, this is Safari-specific.

@samanpwbb

This comment has been minimized.

Show comment Hide comment
@samanpwbb

samanpwbb Dec 21, 2012

Member

@tmcw hrm, i'm definitely on Chrome. (version 23.0.1271.101)

Member

samanpwbb commented Dec 21, 2012

@tmcw hrm, i'm definitely on Chrome. (version 23.0.1271.101)

@tmcw tmcw closed this in 4989768 Dec 27, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment