Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show tooltip for long background names #3448

Closed
boothym opened this issue Sep 23, 2016 · 5 comments
Closed

Show tooltip for long background names #3448

boothym opened this issue Sep 23, 2016 · 5 comments
Labels
usability An issue with ease-of-use or design

Comments

@boothym
Copy link
Contributor

boothym commented Sep 23, 2016

Similar to #3447 there is also a problem where backgrounds with long names are not fully visible. I notice bing/mapbox/osm have tooltip descriptions which pop-up. Can the same be done with for other backgrounds?

@bhousel
Copy link
Member

bhousel commented Oct 26, 2016

The tooltips for the background imagery sources are taken from the editor-layer-index project. If the source has a description property, we show it in a tooltip. So the best way to get a tooltip is to update the source description on that project.

For example: the TIGER2014 layer says "At zoom level 16+, public domain map data from the US Census...." because of this description property.

iD adds some descriptions to global sources that don't have them - we should probably move these descriptions over to the sources themselves...

@bhousel bhousel closed this as completed Oct 26, 2016
@boothym
Copy link
Contributor Author

boothym commented Oct 31, 2016

So should I just copy the name to the description or come up with a description that mentions the full name? I'm happy to do the latter but since it's iD that is doing the truncating with the CSS padding-right I was hoping it could be solved in iD itself. :)

Perhaps iD could show the name in the tooltip, only if the description is empty and the name is longer than say, 32 characters? That way any new background which appears with a long name and no description can be shown.

@bhousel
Copy link
Member

bhousel commented Oct 31, 2016

hmm, I see what you mean, yes iD should probably show something for long names that are cut off. Sorry I closed it bc I thought it was just about adding tooltips to sources that didn't have them.

@bhousel bhousel reopened this Oct 31, 2016
@bhousel bhousel added enhancement usability An issue with ease-of-use or design and removed enhancement labels Nov 1, 2016
@boothym
Copy link
Contributor Author

boothym commented Mar 17, 2017

Is there somewhere to test this, as https://www.openstreetmap.us/iD/master/ is 404?

@bhousel
Copy link
Member

bhousel commented Mar 17, 2017

@boothym Can you try with http://id.openstreetmap.us.s3-website-us-east-1.amazonaws.com/master/

The openstreetmap.us server changed, so our mirrors are on s3 now, and I need to update the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
usability An issue with ease-of-use or design
Projects
None yet
Development

No branches or pull requests

2 participants