Support Arabic vowel signs, include more languages in generic RTL fix #3923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes the Arabic-specific regex and fix which we implemented earlier, and extends it to two other right-to-left scripts (Hebrew, and Thaana from the Maldives)
These two languages don't need special text-shaping like we did for Arabic, just right-to-left reversal to handle the Chrome bug, and keeping vowel signs together with the letter that they modify (sort of like
N + ̃ = Ñ- reversing the string should not change which letter gets the tilde)The Arabic code also gets the fix for vowel signs