It is not possible to enter the letters Ś and ś in Polish language.

[Slawek234]

It is not possible during editing to enter the letters Ś and ś in Polish language.
By choosing the alt(right)+s combination instead of the letter ś, the ID editor tries to save changes.
OS Windows 10 64bit
Webbrowser Firefox 58.0.2 (32 bity), Opera 50.0.2762.67 (PGO)

[maraf24]

Pressing Right Alt + S on "polish programmer keyboard" layout - standard layout in Poland - generates Ctrl-Alt-S keyboard event.
In application - here iD - this event must be unhandled for the letter Ś to appear in edit field.
And this is where problem lies: you can invoke saving changes in iD by pressing Ctrl-Alt-S, Ctrl-Shift-S and Ctrl-S. However only the last shortcut is officially supported.
In order to fix the problem, we need Ctrl-Alt-S to stop working as a keyboard shortcut.

[bhousel]

And this is where problem lies: you can invoke saving changes in iD by pressing Ctrl-Alt-S, Ctrl-Shift-S and Ctrl-S. However only the last shortcut is officially supported.
In order to fix the problem, we need Ctrl-Alt-S to stop working as a keyboard shortcut.

Ok I think I understand how to fix this. We'd need to make sure not to match the shortcut if Alt is pressed.

Just to make sure, is Ctrl-S a normal shortcut to use for a Save command in a Polish localization?
In en-US, it's pretty much universal that Ctrl-S means "save", but I wouldn't want to assume that this is true for Polish too:

[maraf24]

Just to make sure, is Ctrl-S a normal shortcut to use for a Save command in a Polish localization?

Yes it is. Even though 'Save' is "Zapisz' in Polish, It wasn't changed as Ctrl+S is a standard shortcut in all Polish-localized software for saving data, probably thanks to popularity of Microsoft Office.

[Slawek234]

In all Polish localization ctrl + s is used for saving (zapisz)
alt(right) + s = ś, alt(right) + shift + s = Ś

[RicoElectrico]

Bump, this is a breaking issue. People on the Polish forum complain about this.

[1ec5]

And this is where problem lies: you can invoke saving changes in iD by pressing Ctrl-Alt-S, Ctrl-Shift-S and Ctrl-S. However only the last shortcut is officially supported.

Unlike many shortcuts in iD, the Save button’s shortcut isn’t localizable:

iD/modules/ui/save.js

Line 20 in 6ce2c5e

var key = uiCmd('⌘S');

For consistency with the other ⌘ and ⇧⌘ shortcuts, the S in Ctrl+S should be localizable. But the problem affecting Polish keyboard layouts appears to because d3 maps ⌘ to more than just Ctrl on Windows. The mapping to modifier keys is implemented largely in d3.keybinding.js. These lines from #4096 may be relevant:

iD/modules/lib/d3.keybinding.js

Lines 83 to 86 in 6ce2c5e

	if (!(event.ctrlKey && event.altKey)) { // if both are set, assume AltGr and skip it - #4096
	if (event.ctrlKey !== binding.event.modifiers.ctrlKey) return false;
	if (event.altKey !== binding.event.modifiers.altKey) return false;
	}

[bhousel]

Bump, this is a breaking issue. People on the Polish forum complain about this.

I'll tag it as "help wanted". I think the people complaining are also in the best position to actually submit a pull request with a fix.

[maraf24]

This problem doesn't occur with latest version of Chrome.
I tested some other browsers:
Vivaldi on Chromium 65 - "ś" not working. Vivaldi on Chromium 68 - "ś" working.
Firefox 62beta - not working; Firefox Nightly - working.

I don't know what they changed.