Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feature's default tags: remember recent past edits #590

Closed
nvkelso opened this issue Feb 1, 2013 · 11 comments
Closed

New feature's default tags: remember recent past edits #590

nvkelso opened this issue Feb 1, 2013 · 11 comments
Projects

Comments

@nvkelso
Copy link

nvkelso commented Feb 1, 2013

It defaults to highway=residential now.

But I've been editing (adding) man_made:pier all day. Each new pier I draw I have to type over these bad highway=residential defaults.

Init to highway=residential, but build dict of recent tags:values and if a trend develops, default to top edit session tag:value pair.

@tmcw
Copy link
Contributor

tmcw commented Feb 1, 2013

👍 Though I'd lik a simple rule of how to do this.. thinking about:

For a new feature, add in tags that you added for the last new feature of that type, but omit name.

Should that cover it?

@nvkelso
Copy link
Author

nvkelso commented Feb 1, 2013

Yes :)

@ansis
Copy link
Collaborator

ansis commented Feb 1, 2013

Yeah, definitely a pain

For a new feature, add in tags that you added for the last new feature of that type, but omit name.

could this be confusing? tags are being set without any direct action by the user

Presets ui isn't finished yet, but it looks like there will be a list of favorites for newly created nodes. What if this were just updated based on recent edits? That only covers the basic tags though

@nvkelso
Copy link
Author

nvkelso commented Feb 1, 2013

Threshold of 2 or 3 uses for added to favorites?

Still think default values are important. Else it's hard to know what to
edit. Tags can be super confusing!

Sent from my handsful device.

On Feb 1, 2013, at 11:17, Ansis Brammanis notifications@github.com wrote:

Yeah, definitely a pain

For a new feature, add in tags that you added for the last new feature of
that type, but omit name.

could this be confusing? tags are being set without any direct action by
the user

Presets ui isn't finished yet, but it looks like there will be a list of *
favorites* for newly created nodes. What if this were just updated based on
recent edits?


Reply to this email directly or view it on
GitHubhttps://github.com//issues/590#issuecomment-13009316.

@tmcw
Copy link
Contributor

tmcw commented Feb 1, 2013

Okay: so @ansis and I have discussed:

So automatically pulling tags from the previous edit would be weird. We don't want this to happen automatically. But a slight change should make this fine:

Next to the presets, we should have like a 'last config' button that fills in the form, and when it does that, it notifies the user by, for instance, flashing the form.

@iandees
Copy link
Collaborator

iandees commented Feb 12, 2013

This needs to be no-click to be useful. Having to click a "last config" button more than doubles the amount of time I have to spend when mapping a bunch of houses or armchair-tracing a bunch of streets.

In JOSM-land, I wrote a very hacky plugin to automatically apply tags from the object copied to the clipboard. That's not exactly obvious, though.

Some ideas:

  • The "last config" button could be a toggle that automatically applied tags from the last object as long as the toggle was on
  • Add an operation to the ops menu: when clicking on an object you can choose "set sticky" ("use this object's tags for future objects"). If sticky is on, the "disable sticky" gets added.

I realize this is a UX nightmare, but it makes it MUCH easier to map. The difference between JOSM with building tools plugin and without is huge. The plugin basically creates a new mode that always applies a building=yes tag to the polygons created while in that mode. It makes it possible to trace an entire city's buildings in a day.

@tmcw
Copy link
Contributor

tmcw commented Mar 13, 2013

We now remember the last preset chosen and push it to the top of the list. It's a few steps away from remembering all tags, but pretty okay.

@nvkelso
Copy link
Author

nvkelso commented Mar 13, 2013

This is much better!

But I'm still having problems with the following use case:

I zoom into Eureka, California. Woodley Island north of downtown has a
bunch of piers. It's not at all clear how I draw more piers. Yes, the
search is there but that requires thinking.

Even though I clicked on the piers to see what their class was, adding a
new line still doesn't have piers in the favorites list.

Request adding a special favorite for last browsed as well as the current
last edited.

_Nathaniel

@mvexel
Copy link
Contributor

mvexel commented Apr 2, 2013

I would like to see a function that would pretty much replicate http://josm.openstreetmap.de/wiki/Help/Action/PasteTags but a little smarter. (omit name= most importantly)
In many UIs this is called 'paste style' and represented with a paintbrush. This I think is common enough to adopt (Word has it)
Does that represent what you are talking about here?

@hajo4
Copy link

hajo4 commented Dec 21, 2014

It looks like iD doesn't remember any settings.
So, every time an iD-session starts, the default/factory-settings are active.
My preferences are not active, they have to be "learned" anew, and
after the session they are forgotten.

Why are they not stored, e.g. in a cookie ?

Example:
I'm using running queries on overpass-turbo.eu to find nodes/ways with some feature/FIXME,
and get a new tab to edit them - with a new "plain" iD-session, that doesn't have my
prefered settings yet.
Quite annoying...

@bhousel
Copy link
Member

bhousel commented Mar 21, 2019

closing here as stale.. Lots has moved since 2013!
#6010, #6022 and others change the top bar to support "favorites" and "recents"

@bhousel bhousel closed this as completed Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Priorities
Toolbar
Development

No branches or pull requests

8 participants