Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach street-level imagery tags to changesets #6279

Closed
cbeddow opened this issue May 1, 2019 · 8 comments

Comments

Projects
None yet
4 participants
@cbeddow
Copy link
Contributor

commented May 1, 2019

When a user opens any of the street-level imagery layers:

  • Bing Streetside
  • Mapillary
  • OpenStreetCam

I suggest that the changeset automatically adds:

  • source=mapillary
  • source= streetlevel imagery
  • hashtag=#mapillary

image

This can be cleared by the user if they don't want to add it. This is helpful for tracking generally how many changesets use street-level imagery, and then knowing the total proportion that use each provider. For Mapillary this helps us to know where out imagery is most useful (and potentially give image capturing users feedback on this so they know they are helping contribute to OSM even when another user is using the images)

@quincylvania

This comment has been minimized.

Copy link
Collaborator

commented May 1, 2019

This could be useful! To reduce false positives, perhaps we could only add the values if a user edits a feature near the photo location with the photo open.

Thinking ahead, if we make iD really good at this then we could possible update the source tag on the feature itself and maybe do automatic photo-linking (#6196). Though I'd still prefer a manual photo-linking UI first.

@pnorman

This comment has been minimized.

Copy link
Contributor

commented May 1, 2019

👎 to a hashtag, it's unnecessary with a source tag.

@cbeddow

This comment has been minimized.

Copy link
Contributor Author

commented May 2, 2019

Just one or other makes sense then, yes. Source is actually useful, hashtag just visible.

The photo linking would be great but too complex for now, yeah. We could even start by sequence-linking (each photo is part of a collection of photos that are a sequence, so it helps).

@cbeddow

This comment has been minimized.

Copy link
Contributor Author

commented May 2, 2019

Also, I am not sure what radius would make sense on having the distance check. 200 meters maybe?

Additionally, would it make sense to have data overlay as a source as well, for example with Mapillary traffic signs layer? So it would have source=mapillary and source=data overlay so that it's differentiated from streetlevel imagery, although it could be both, if both are active and used. Can reconsider this at another time if it complicates things though.

@quincylvania quincylvania self-assigned this May 7, 2019

@quincylvania

This comment has been minimized.

Copy link
Collaborator

commented May 16, 2019

@cbeddow FYI it looks like iD already includes info on the photo layers in the imagery_used changeset tag if the user makes an edit with an overlay enabled. Perhaps this is enough to get you started? For example:

imagery_used=DigitalGlobe Premium Imagery;Bing Streetside;Mapillary Images;OpenStreetCam Images

There are a number of reasons this should be improved though:

  • If the user opens a lot of imagery then these values might not fit in the tag, which is limited to 255 characters.
  • The user can't edit it to specify whether they actually used these as sources.
  • There's plenty more information that iD could pass on, like the sequence or photos actually opened during edits.

@quincylvania quincylvania added this to the 2.15.0 milestone May 16, 2019

@quincylvania

This comment has been minimized.

Copy link
Collaborator

commented May 16, 2019

@cbeddow I made it so the relevant photo overlay values are also added to the source tag, where users can edit them if needed.

@tordans

This comment has been minimized.

Copy link
Contributor

commented May 18, 2019

@quincylvania I think there is a bug with this new feature. But my test case is not great.

  1. I opened http://preview.ideditor.com/master/#background=Berlin-2018&disable_features=boundaries&locale=en&map=18.00/52.47342/13.44771 via bookmark
  2. I delete something, then added Mapillary, clicked around, deleted more …
  3. I checked the source-filed on the save-screen which was first empty but later had data <--- bad test case :-)
  4. I tried to reproduce my test case, closed the map, re-opened
  5. Choose "delete all data from the last session" on the starting prompt
  6. Did not open any Mapillary layer
  7. Changed something random
  8. => The save-screen sho still shows sources, even though I never added them to this session
    I expected the source area to only check what I did in this session; or maybe even only in this commit-cycle (so it would reset after I saved) and re-check what sources I used before saving again …

Might this be related to the commit-tagging-feature, which has also a memory feature between session?

Bildschirmfoto 2019-05-18 um 07 43 47


(Unrelated to this and more for myself: A ping from here to #6300.)

@quincylvania

This comment has been minimized.

Copy link
Collaborator

commented May 20, 2019

@tordans Interesting. This is definitely because some of the changeset tags are persisted in local storage. Not sure if this is a bug or a feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.