Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brand tag linking to non existend logo picture #7028

Closed
fnordson opened this issue Nov 7, 2019 · 15 comments
Closed

Brand tag linking to non existend logo picture #7028

fnordson opened this issue Nov 7, 2019 · 15 comments
Assignees
Labels
Milestone

Comments

@fnordson
Copy link

@fnordson fnordson commented Nov 7, 2019

brand=Rewe
brand:wikidata=Q16968817
brand:wikipedia=en:REWE

shows a broken image link:

rewe

File seems to link to: https://graph.facebook.com/Rewe/picture?type=large
The logo is also available here: https://de.wikipedia.org/wiki/Rewe_(Markt)

@scaidermern

This comment has been minimized.

Copy link
Contributor

@scaidermern scaidermern commented Nov 7, 2019

@Developers:
Is it really necessary to tell Facebook about an OSM user currently editing a supermarket? Can you please remove this nonsense? Either host these images on your server or just use a generic icon. But stop linking to Facebook and similar organizations. Respect our privacy, please.

@bhousel

This comment has been minimized.

Copy link
Member

@bhousel bhousel commented Nov 7, 2019

I've seen this reported a few times.. What's probably happening is either your browser or a plugin is blocking the call to facebook to get the image.

We are going to:

  • add an onError handler to show the fallback preset image
  • add an option so that users can disable the brand icons

@scaidermern Please be nice. Features that give users feedback and improve the quality of the data in OSM are not "nonsense". Maybe you should have more respect for the work that the maintainers have put into making iD a good editor.

@bhousel bhousel added the enhancement label Nov 7, 2019
@scaidermern

This comment has been minimized.

Copy link
Contributor

@scaidermern scaidermern commented Nov 7, 2019

@scaidermern Please be nice. Features that give users feedback and improve the quality of the data in OSM are not "nonsense". Maybe you should have more respect for the work that the maintainers have put into making iD a good editor.

I didn't had the intention to insult anybody. iD is indeed a great editor and makes editing really easy for new mappers. However there is no need to link to such external resources and to undermine user's privacy. People aren't expecting automatic calls to Facebook in the background when firing up their OSM editor. Facebook is already collecting more than enough data.

@bhousel

This comment has been minimized.

Copy link
Member

@bhousel bhousel commented Nov 7, 2019

However there is no need to link to such external resources and to undermine user's privacy.

How do you think the background imagery works?

@scaidermern

This comment has been minimized.

Copy link
Contributor

@scaidermern scaidermern commented Nov 7, 2019

However there is no need to link to such external resources and to undermine user's privacy.

How do you think the background imagery works?

The same way. However the user is able to choose which aerial imagery to use.

@fnordson

This comment has been minimized.

Copy link
Author

@fnordson fnordson commented Nov 7, 2019

I've seen this reported a few times.. What's probably happening is either your browser or a plugin is blocking the call to facebook to get the image.

I agree this is probably it.

I also agree with @scaidermern on the privacy issue especially because there are better sources and the facebook ping is really unnecessary.

@bhousel

This comment has been minimized.

Copy link
Member

@bhousel bhousel commented Nov 7, 2019

because there are better sources

What are the better sources of "all the logos for all the brands in the world"?

the facebook ping is really unnecessary.

Sure, I mean, all of this is unnecessary, when you really think about it.

@fnordson

This comment has been minimized.

Copy link
Author

@fnordson fnordson commented Nov 7, 2019

because there are better sources

What are the better sources of "all the logos for all the brands in the world"?

The logo is also available here: https://de.wikipedia.org/wiki/Rewe_(Markt)

Other logos work without issues for example the Burger King Logo which links to: https://upload.wikimedia.org/wikipedia/commons/thumb/3/3a/Burger_King_Logo.svg/100px-Burger_King_Logo.svg.png

Sure, I mean, all of this is unnecessary, when you really think about it.

Please be nice. Features that give users feedback and improve the quality of the data in OSM are not "nonsense". Maybe you should have more respect for the work that the maintainers have put into making iD a good editor.

;)

Edit: Same issue with: Rossmann, Lidl, Kik, NKD, Takko, Edeka,

@bhousel

This comment has been minimized.

Copy link
Member

@bhousel bhousel commented Nov 7, 2019

Look guys. Today I would just be happy to get this project building again.

The build is broken, I'm burnt out, and I don't even want to work on it anymore. I don't have the energy to debate you all on whether it makes sense to fetch logos from Facebook. I don't like doing this work anymore when it's just become me fixing broken stuff, putting out fires, and responding to unhelpful critics who contribute nothing. This is an Open Source project and I don't owe you anything.

If you want to compare logo coverage, check out https://nsi.guide and you'll see that the Wikidata logos are not a sufficient replacement for what we get from Facebook. (I've put a lot of work into that project too, for what it's worth).

@bhousel

This comment has been minimized.

Copy link
Member

@bhousel bhousel commented Nov 7, 2019

Also please stop editing your comment. The NSI contains about 4000 entries, and if your browser is blocking Facebook, they will all show up with no images. You don't need to enumerate the list of all of them.

@openstreetmap openstreetmap locked as too heated and limited conversation to collaborators Nov 7, 2019
@quincylvania quincylvania added this to the 2.16.1 milestone Nov 7, 2019
@quincylvania quincylvania self-assigned this Nov 7, 2019
@quincylvania

This comment has been minimized.

Copy link
Collaborator

@quincylvania quincylvania commented Nov 7, 2019

I made it so that the vector preset icon is shown if the image fails to load:

Screen Shot 2019-11-07 at 8 11 39 PM

@openstreetmap openstreetmap unlocked this conversation Nov 8, 2019
@Bibi56

This comment has been minimized.

Copy link

@Bibi56 Bibi56 commented Nov 9, 2019

Thanks @quincylvania for that.

I'm burnt out, and I don't even want to work on it anymore. I don't have the energy to debate you all on whether it makes sense to fetch logos from Facebook. I don't like doing this work anymore when it's just become me fixing broken stuff, putting out fires, and responding to unhelpful critics who contribute nothing. This is an Open Source project and I don't owe you anything.

Right, you owe something to MapBox and that maybe an issue. Not that working for MapBox is an issue, but that you may loose the contact to the community to make the editor the community wants.
Before developing a feature think about the way this feature can be wanted or offending the community. Otherwise you get what you take as a rough comment. Don't forget the last word of @scaidermern: please.

So you think that displaying the logo of a company helps finding the right name.
You check the coverage for logos and you discover that Facebook has the best coverage.
So you want to use that.
Until now, nothing wrong as such.
But you missed to take into account the privacy concern.

iD is used on OpenStreetMap.org and therefore needs to reflect the will/wishes of the community.
Privacy concern, probably more in Germany and France than US is an important topic.
Solutions for that exist: calls to a proxy, hosted for instance by the foundation.
That way you can move forward, not loosing your energy or will in dealing with stuff you don't want to deal with.
Make a break and come back in a good mood, full of energy.

@ImreSamu

This comment has been minimized.

Copy link

@ImreSamu ImreSamu commented Nov 12, 2019

@quincylvania :

I made it so that the vector preset icon is shown if the image fails to load:

imho:

  • the current solutions ( == "vector preset icon") is just a fix for the "word trademark" ; and we need to find a solution for the "Figurative trademark" problem;
  • it is not an easy problem ...

just a side note:

My Example for "Figurative trademark" ( ~ "Logo Brand" ) is "amenity/cafe|Caffè Nero"

disclaimer:

  • I am biased in this topic - because I am part of the local community data quality team.

A picture of a cute animal (not mandatory but encouraged)

image
( image source )
the docker project has a best practice - protecting the maintainers/readers emotions ... ( ~ "A picture of a cute animal" ) Maybe we need a similar solutions ...
We need a a cute factor for the heated debate.

@pyrog

This comment has been minimized.

Copy link

@pyrog pyrog commented Nov 12, 2019

Solutions for that exist: calls to a proxy, hosted for instance by the foundation.

👍

@pyrog

This comment has been minimized.

Copy link

@pyrog pyrog commented Nov 12, 2019

Logo could be imported to wikidata ?

2081 brands and 207 brands with logo (with various quality) https://w.wiki/Bvs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.