-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brand tag linking to non existend logo picture #7028
Comments
@Developers: |
I've seen this reported a few times.. What's probably happening is either your browser or a plugin is blocking the call to facebook to get the image. We are going to:
@scaidermern Please be nice. Features that give users feedback and improve the quality of the data in OSM are not "nonsense". Maybe you should have more respect for the work that the maintainers have put into making iD a good editor. |
I didn't had the intention to insult anybody. iD is indeed a great editor and makes editing really easy for new mappers. However there is no need to link to such external resources and to undermine user's privacy. People aren't expecting automatic calls to Facebook in the background when firing up their OSM editor. Facebook is already collecting more than enough data. |
How do you think the background imagery works? |
The same way. However the user is able to choose which aerial imagery to use. |
I agree this is probably it. I also agree with @scaidermern on the privacy issue especially because there are better sources and the facebook ping is really unnecessary. |
What are the better sources of "all the logos for all the brands in the world"?
Sure, I mean, all of this is unnecessary, when you really think about it. |
The logo is also available here: https://de.wikipedia.org/wiki/Rewe_(Markt) Other logos work without issues for example the Burger King Logo which links to: https://upload.wikimedia.org/wikipedia/commons/thumb/3/3a/Burger_King_Logo.svg/100px-Burger_King_Logo.svg.png
Please be nice. Features that give users feedback and improve the quality of the data in OSM are not "nonsense". Maybe you should have more respect for the work that the maintainers have put into making iD a good editor. ;) Edit: Same issue with: Rossmann, Lidl, Kik, NKD, Takko, Edeka, |
Look guys. Today I would just be happy to get this project building again. The build is broken, I'm burnt out, and I don't even want to work on it anymore. I don't have the energy to debate you all on whether it makes sense to fetch logos from Facebook. I don't like doing this work anymore when it's just become me fixing broken stuff, putting out fires, and responding to unhelpful critics who contribute nothing. This is an Open Source project and I don't owe you anything. If you want to compare logo coverage, check out https://nsi.guide and you'll see that the Wikidata logos are not a sufficient replacement for what we get from Facebook. (I've put a lot of work into that project too, for what it's worth). |
Also please stop editing your comment. The NSI contains about 4000 entries, and if your browser is blocking Facebook, they will all show up with no images. You don't need to enumerate the list of all of them. |
Thanks @quincylvania for that.
Right, you owe something to MapBox and that maybe an issue. Not that working for MapBox is an issue, but that you may loose the contact to the community to make the editor the community wants. So you think that displaying the logo of a company helps finding the right name. iD is used on OpenStreetMap.org and therefore needs to reflect the will/wishes of the community. |
imho:
just a side note:
My Example for "Figurative trademark" ( ~ "Logo Brand" ) is
disclaimer:
|
👍 |
Logo could be imported to wikidata ? 2081 brands and 207 brands with logo (with various quality) https://w.wiki/Bvs |
brand=Rewe
brand:wikidata=Q16968817
brand:wikipedia=en:REWE
shows a broken image link:
File seems to link to: https://graph.facebook.com/Rewe/picture?type=large
The logo is also available here: https://de.wikipedia.org/wiki/Rewe_(Markt)
The text was updated successfully, but these errors were encountered: