Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Biergarten preset #7222

Closed
maro-21 opened this issue Jan 5, 2020 · 5 comments
Closed

Edit Biergarten preset #7222

maro-21 opened this issue Jan 5, 2020 · 5 comments
Assignees
Labels
preset An issue with an OpenStreetMap preset or tag
Milestone

Comments

@maro-21
Copy link

maro-21 commented Jan 5, 2020

Remove outdoor_seating:
Amenity=biergarten is itself an outdoor seating so this tag doesn't make sense.

Remove air_conditioning:
amenity=biergarten+air_conditioning: 1 feature

Remove building:
Although there are 1166 features on OSM amenity=biergarten+building, I don't understand how can an open-air area be a building or inside a building. One excludes the other.
Wiki: "A biergarten is an open-air area with benches ..."
See also photos there.

I think features with amenity=biergarten+building can come from people who confused biergarten with a pub.

Add cuisine to More Fields.
amenity=biergarten+cuisine: 276 features

amenity=biergarten: 10132 features
amenity=biergarten+building: 1166
amenity=biergarten+outdoor_seating: 546
amenity=biergarten+cuisine: 276
amenity=biergarten+air_conditioning: 1

@tas50
Copy link

tas50 commented Jan 5, 2020

I would suspect a lot of those biergarten tags on buildings are in the US. It's pretty common to have indoor shared table seating pubs with German beer here. People in the US would consider that to be a biergarten even if it doesn't strictly meet the guidelines of the wiki.

@quincylvania
Copy link
Collaborator

@maro-21 The extra fields are there to accommodate biergarten variations that may exist around the world. In the US, for example, alcohol generally cannot be consumed in public spaces, so biergartens may indeed be indoor "beer halls" or be covered by a building=roof.

That said, I'm okay with moving the Building field to moreFields.

@quincylvania quincylvania added the preset An issue with an OpenStreetMap preset or tag label Jan 6, 2020
@quincylvania quincylvania added this to the 2.17.1 milestone Jan 6, 2020
@quincylvania quincylvania self-assigned this Jan 6, 2020
@maro-21
Copy link
Author

maro-21 commented Jan 6, 2020

What about removing outdoor_seating?

@quincylvania
Copy link
Collaborator

What about removing outdoor_seating?

I think it's okay for people to add this. Imagine a POI app that has an option to filter by "outside seating". This tag keeps the data model consistent with cafes, restaurants, etc. without making the app developer do more work.

@maro-21
Copy link
Author

maro-21 commented Jan 7, 2020

So either every biergarten should have it or none. Because now it looks like a world is divided into biergartens with an outdoor seating and biergartens without an outdoor seating...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preset An issue with an OpenStreetMap preset or tag
Projects
None yet
Development

No branches or pull requests

3 participants