Notes

[tmcw]

Oh boy. This adds notes functionality to iD, this addressing #1393

Right now it takes the approach that:

• Notes have their own mode and ui
• Notes are in the history/graph and have the prefix 'e'
• In some places notes need to be explicitly excluded so they aren't dragged/selected/etc.

Todos:

• Re-add the show-notes toggle
• Tests
• Should this be able to create a new note? Ugh.
• The comment-posting UI 'lies' but that's probably all right.
• The styling could be cleaner
• We could use a notes icon instead of a blank circle as I'm doing now
• Refactor note-versus-point CSS
• Notes should have halos too?

[jfirebaugh]

Seems like a good approach to me.

Would it be cleaner if note SVG elements were not classed point though?

[jfirebaugh]

This class is no longer used, right?

[tmcw]

Would it be cleaner if note SVG elements were not classed point though?

Yes, this is currently an icky point; needs CSS refactoring

[tmcw]

@samanpwbb Do you have thoughts on how notes should be shown with the map in iD? On osm they have hacky leaflet-esque markers with green/red colors.

[samanpwbb]

@tmcw as much as I'd like to restyle these to be better looking, I think the best approach right now is to make notes in iD as close as possible to notes in osm.org, for the sake of familiarity, and so the two can evolve together.

[mourner]

Is this on hold now?

[jfirebaugh]

Yes, iD's kind of in low maintenance mode currently.

[ToeBee]

Just to poke things a little, as of an hour ago, josm-latest now has (very basic) note support built into core :)

On a more serious note, it looks like iD is running into some of the same issues I did when adding note support to JOSM. Notes are part of the OSM API but are different from all other API objects in that they don't involve versions, tags or changesets. It does make things kind of awkward...