Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for displaying esri metadata #4335

Merged
merged 2 commits into from Sep 12, 2017
Merged

add support for displaying esri metadata #4335

merged 2 commits into from Sep 12, 2017

Conversation

jgravois
Copy link

@jgravois jgravois commented Sep 10, 2017

resolves #4280

  • restricts fetching metadata when zoomed to 13 or tighter
  • adds a new line to the metadata panel when Esri imagery is active to display the individual provider (NAIP, DigitalGlobe, Municipality etc.)

screenshot 2017-09-09 22 00 42

@jgravois
Copy link
Author

@jgravois jgravois commented Sep 10, 2017

we have info on imagery accuracy and resolution too. if thats interesting, just say the word.

@bhousel
Copy link
Member

@bhousel bhousel commented Sep 10, 2017

we have info on imagery accuracy and resolution too. if thats interesting, just say the word.

This looks great! I do think people would be interested in seeing accuracy and resolution too, so go ahead and add 👍

Maybe we should just rename getVintage to getMetadata.. The object that it passes to the callback could have all kinds of useful stuff in it.

* getVintage() becomes getMetadata()
* ignore a couple unrelated lint nags
* add source description, resolution and accuracy info to debug panel
@jgravois
Copy link
Author

@jgravois jgravois commented Sep 11, 2017

pushed another commit to incorporate @bhousel's suggestions.

screenshot 2017-09-11 09 54 10

i didn't know how to internationalize '(m)' so i just hardcoded it.

@pnorman
Copy link
Contributor

@pnorman pnorman commented Sep 12, 2017

You shouldn't add brackets around units.

@jgravois
Copy link
Author

@jgravois jgravois commented Sep 12, 2017

You shouldn't add brackets around units.

thats fine by me. transifex would probably like it if i spelled out 'meters' anyway.

@bhousel
Copy link
Member

@bhousel bhousel commented Sep 12, 2017

You shouldn't add brackets around units.

thats fine by me. transifex would probably like it if i spelled out 'meters' anyway.

Thanks @jgravois ! I'll clean up the strings, but this is mostly fine. I'll merge it tomorrow morning.

FWIW the measurement pane and scale bar both have hardcoded unit strings for things like "m", "ft" etc, and nobody has complained yet. 👌

@bhousel bhousel merged commit 5f34136 into openstreetmap:master Sep 12, 2017
1 check passed
@bhousel
Copy link
Member

@bhousel bhousel commented Sep 12, 2017

Just merged this, thanks again @jgravois!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants