New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added plot preset #4427

Merged
merged 2 commits into from Oct 11, 2017

Conversation

Projects
None yet
3 participants
@humanforklift
Contributor

humanforklift commented Oct 11, 2017

I have added a new presets JSON file for place=plot.

I'm new to this, so let me know if I need to change anything.

Show outdated Hide outdated data/presets/presets/place/plot.json Outdated
@bhousel

This comment has been minimized.

Show comment
Hide comment
@bhousel

bhousel Oct 11, 2017

Member

Thanks so much for your contribution! The plot.json file looks great - I requested a minor change for the search terms array.

Member

bhousel commented Oct 11, 2017

Thanks so much for your contribution! The plot.json file looks great - I requested a minor change for the search terms array.

@bhousel bhousel referenced this pull request Oct 11, 2017

Closed

Add preset for place=plot #4423

@humanforklift

This comment has been minimized.

Show comment
Hide comment
@humanforklift

humanforklift Oct 11, 2017

Contributor

Thanks for letting me know. I have updated the search terms array, so hopefully now it should contain synonyms as requested.

Contributor

humanforklift commented Oct 11, 2017

Thanks for letting me know. I have updated the search terms array, so hopefully now it should contain synonyms as requested.

@bhousel

This comment has been minimized.

Show comment
Hide comment
@bhousel

bhousel Oct 11, 2017

Member

Thanks for your contribution @humanforklift , looks great 👍

Member

bhousel commented Oct 11, 2017

Thanks for your contribution @humanforklift , looks great 👍

@bhousel bhousel merged commit d52e72d into openstreetmap:master Oct 11, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Nakaner

This comment has been minimized.

Show comment
Hide comment
@Nakaner

Nakaner Oct 12, 2017

I don't think that adding a preset for place=plot is a good idea. As another user pointed out on IRC yesterday, mapping plots might lead the OpenStreetMap project into legal trouble with data protection regulation in the European Union and some other countries in Europe. Having data which falls under these regulation in the planet could hinder distribution and usage of the data in several countries.

By adding the preset to the "official" editor (it is embedded into the official web page of the project) people could have the impression that it is permitted [1] to map them. In addition, the presets asks for a name tag. What will the name of mapped parcels be? I fear that it will be the name of the owner.

I abstain from writing down more arguments against this tag because this bug tracker is not the tagging mailing list.

Therefore, I would like to ask all who are involved to reconsider their decision.

A technical comment: Why is the diff of this pull request so large? The pull request aims to add a single tagging preset but changes lots of other files. Is this necessary?

[1] I know the "you can tag what you want roule"

Nakaner commented Oct 12, 2017

I don't think that adding a preset for place=plot is a good idea. As another user pointed out on IRC yesterday, mapping plots might lead the OpenStreetMap project into legal trouble with data protection regulation in the European Union and some other countries in Europe. Having data which falls under these regulation in the planet could hinder distribution and usage of the data in several countries.

By adding the preset to the "official" editor (it is embedded into the official web page of the project) people could have the impression that it is permitted [1] to map them. In addition, the presets asks for a name tag. What will the name of mapped parcels be? I fear that it will be the name of the owner.

I abstain from writing down more arguments against this tag because this bug tracker is not the tagging mailing list.

Therefore, I would like to ask all who are involved to reconsider their decision.

A technical comment: Why is the diff of this pull request so large? The pull request aims to add a single tagging preset but changes lots of other files. Is this necessary?

[1] I know the "you can tag what you want roule"

@bhousel

This comment has been minimized.

Show comment
Hide comment
@bhousel

bhousel Oct 12, 2017

Member

By adding the preset to the "official" editor (it is embedded into the official web page of the project) people could have the impression that it is permitted [1] to map them.

There are 28k of them already mapped and it has an osm wiki page. It's an established tag, so that's why we added a preset. I try to avoid make decisions about whether something "belongs" in OSM or not. If people want it mapped and they are using legal sources, that is good enough for me.

In addition, the presets asks for a name tag. What will the name of mapped parcels be? I fear that it will be the name of the owner.

Presets like "Building" and "House" support a name field too. It's also discouraged to put people's real names there, but nobody is calling to remove the building presets just because a few mappers might make that mistake.

I do think adding rules to OSMCha like "Name added to Building" or "Name added to Plot" would be a good way to surface issues like this to local reviewers.

I don't actually know how the tag is used, but if name really doesn't make sense, we could remove it.
Also I think adding a ref field might make more sense. I know this differs all around the world - where I live plots are usually referred to by Block/Lot numbers.

I abstain from writing down more arguments against this tag because this bug tracker is not the tagging mailing list.

Feel free to discuss on the mailing list.. I'll see it, but I usually don't participate unless somebody tries to suggest a tag scheme that is technically difficult for us to support. If the OSM community decides to remove all of these from the database and wiki, I'll happily remove the preset too.

A technical comment: Why is the diff of this pull request so large? The pull request aims to add a single tagging preset but changes lots of other files. Is this necessary?

The user who submitted the pull request is a new contributor (thank you!!), and rebuild the generated presets file using outdated name-suggestion and editor-imagery dependencies. This is a minor issue, so I just rebuilt them myself (2bb7b5a) using updated dependencies.

Member

bhousel commented Oct 12, 2017

By adding the preset to the "official" editor (it is embedded into the official web page of the project) people could have the impression that it is permitted [1] to map them.

There are 28k of them already mapped and it has an osm wiki page. It's an established tag, so that's why we added a preset. I try to avoid make decisions about whether something "belongs" in OSM or not. If people want it mapped and they are using legal sources, that is good enough for me.

In addition, the presets asks for a name tag. What will the name of mapped parcels be? I fear that it will be the name of the owner.

Presets like "Building" and "House" support a name field too. It's also discouraged to put people's real names there, but nobody is calling to remove the building presets just because a few mappers might make that mistake.

I do think adding rules to OSMCha like "Name added to Building" or "Name added to Plot" would be a good way to surface issues like this to local reviewers.

I don't actually know how the tag is used, but if name really doesn't make sense, we could remove it.
Also I think adding a ref field might make more sense. I know this differs all around the world - where I live plots are usually referred to by Block/Lot numbers.

I abstain from writing down more arguments against this tag because this bug tracker is not the tagging mailing list.

Feel free to discuss on the mailing list.. I'll see it, but I usually don't participate unless somebody tries to suggest a tag scheme that is technically difficult for us to support. If the OSM community decides to remove all of these from the database and wiki, I'll happily remove the preset too.

A technical comment: Why is the diff of this pull request so large? The pull request aims to add a single tagging preset but changes lots of other files. Is this necessary?

The user who submitted the pull request is a new contributor (thank you!!), and rebuild the generated presets file using outdated name-suggestion and editor-imagery dependencies. This is a minor issue, so I just rebuilt them myself (2bb7b5a) using updated dependencies.

@humanforklift

This comment has been minimized.

Show comment
Hide comment
@humanforklift

humanforklift Oct 12, 2017

Contributor

Apologies if I caused any confusion - definitely still getting the hang of this. How can I avoid using outdated name-suggestion and editor-imagery dependencies in the future?

Contributor

humanforklift commented Oct 12, 2017

Apologies if I caused any confusion - definitely still getting the hang of this. How can I avoid using outdated name-suggestion and editor-imagery dependencies in the future?

@bhousel

This comment has been minimized.

Show comment
Hide comment
@bhousel

bhousel Oct 12, 2017

Member

Apologies if I caused any confusion - definitely still getting the hang of this. How can I avoid using outdated name-suggestion and editor-imagery dependencies in the future?

I think running npm install would have updated them, but no apology needed.. This only happened because I was preparing a new release for iD the same time you were preparing the PR.

Member

bhousel commented Oct 12, 2017

Apologies if I caused any confusion - definitely still getting the hang of this. How can I avoid using outdated name-suggestion and editor-imagery dependencies in the future?

I think running npm install would have updated them, but no apology needed.. This only happened because I was preparing a new release for iD the same time you were preparing the PR.

@bhousel bhousel referenced this pull request Nov 10, 2017

Merged

Update to iD v2.5.0 #1675

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment