New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenStreetCam Support! #4499

Merged
merged 12 commits into from Nov 7, 2017

Conversation

Projects
None yet
2 participants
@bhousel
Member

bhousel commented Nov 3, 2017

This PR adds support for OpenStreetCam to iD 馃帀

It works pretty ok right now, but I'll improve a few things:

  • change the marker style to be distinct from Mapillary
  • add attribution / link to openstreetcam.org
  • add username
  • add date captured
  • add some viewer controls? (forward/back.. maybe rotate image?)

screenshot 2017-11-03 16 47 51

cc @mvexel

bhousel added some commits Nov 3, 2017

WIP: Add OpenStreetCam support
todo: Need to figure out API issue with bbox, then imageviewer
@bhousel

This comment has been minimized.

Show comment
Hide comment
@bhousel

bhousel Nov 6, 2017

Member

Going with greenish for Mapillary, bluish for OpenStreetcam:

High Zoom:
screenshot 2017-11-05 22 19 39

Low Zoom:
screenshot 2017-11-05 22 21 31

Member

bhousel commented Nov 6, 2017

Going with greenish for Mapillary, bluish for OpenStreetcam:

High Zoom:
screenshot 2017-11-05 22 19 39

Low Zoom:
screenshot 2017-11-05 22 21 31

@bhousel

This comment has been minimized.

Show comment
Hide comment
@bhousel

bhousel Nov 6, 2017

Member

I hacked together some viewer controls this morning.. Rotate buttons work and will apply the rotation for all images on that sequence. TODO: forward/back buttons, then merging 馃憤

viewer-controls

Member

bhousel commented Nov 6, 2017

I hacked together some viewer controls this morning.. Rotate buttons work and will apply the rotation for all images on that sequence. TODO: forward/back buttons, then merging 馃憤

viewer-controls

This was referenced Nov 7, 2017

@bhousel bhousel merged commit d686766 into master Nov 7, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@mvexel

This comment has been minimized.

Show comment
Hide comment
@mvexel

mvexel Nov 8, 2017

Contributor

Belated 馃帀馃寢!!!

Contributor

mvexel commented Nov 8, 2017

Belated 馃帀馃寢!!!

@bhousel bhousel referenced this pull request Nov 10, 2017

Merged

Update to iD v2.5.0 #1675

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment