Polish Address Format fix #4784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thanks @MKuranowski ! |
|
@MKuranowski please revert this change. |
|
Sorry @maraf24 but @MKuranowski and @Slawek234 raise some good points.. Supporting multiple alternate per-country address formats per #2898 is the ideal solution we want to get to - not just putting all the fields on one form and expecting the user to know which ones to use. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The current Polish address fields format includes
addr:placealongsideaddr:street, which could make it prone to inexperienced users to enter both fileds - and this is, according to OSM Wiki, an error.This PR simply removes the
addr:placeformat. Main discussion on implementingaddr:placeis held under #2898.Also, the Polish placeholders for
addr:placeandaddr:cityare the same ("Miejscowość"), which only makes more confusion.