Adds presets for Traffic Sign, Speed Limit Sign, and City Limit Sign #5333
Each preset has a two variants—point and vertex—to account for different direction fields. The vertex variant uses the
This also includes a small code change to make the
Hey @quincylvania - thanks again for all your work on the presets recently
I think it's great that these presets support both street signs either mapped as their own point alongside the way or as a vertex along a way.
When reviewing this, I noticed an issue with the directional tagging of street signs. This is not actually an issue in what you did, but more an oddity in the osm-wiki-recommended way of tagging street sign directions.
Cool! iD supports this, and it's what you did...
Whoa! So that's a problem. Your presets actually use
But the wiki says we are supposed to do something like
So my recommendation is for you to change the sign-as-vertex presets so that traffic sign direction tagging works exactly like traffic signal direction tagging.
...and I'm proposing to create:
I will draft a message to the tagging mailing list today to let people know about the issue and that iD is going a different "direction" from what the wiki recommends (hah).
Hi @bhousel, thanks for the feedback!
I hadn't realized the direction issue beforehand. Your solution sounds good to me; I have made the changes in the latest commit. Conveniently, iD already renders view cones for any tag with the
Let me know when we're clear to merge!