Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fields to bench preset and create seats field #5387

Merged
merged 2 commits into from Oct 9, 2018

Conversation

simonbilskyrollins
Copy link
Contributor

Fixes issue #5367

@quincylvania
Copy link
Collaborator

@simonbilskyrollins Thanks! Could you add "minValue": 0 to the seats field? Nobody wants negative seats 😆

Also, consider adding some placeholder like "placeholder": "2, 4, 6..." to the field to indicate that it's numeric.

@simonbilskyrollins
Copy link
Contributor Author

@quincylvania good point! I've added both of those things to the PR.

@bhousel
Copy link
Member

bhousel commented Oct 9, 2018

@simonbilskyrollins - thanks for your PR! 👍
@quincylvania - good catch on the "negative seats" 😆

@bhousel bhousel merged commit 822e24d into openstreetmap:master Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants