Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #6617 #7055

Merged
merged 1 commit into from Nov 20, 2019
Merged

Conversation

@CarycaKatarzyna
Copy link
Contributor

CarycaKatarzyna commented Nov 19, 2019

This concerns issue #6617 . When user clicks on "Use a bridge"/"Use a tunnel" it splits edge if is long and creates bridge/tunnel. Later user may correct bridge/tunnel location by manually shifting nodes.

@quincylvania quincylvania self-assigned this Nov 20, 2019
@quincylvania quincylvania merged commit 3e022b8 into openstreetmap:master Nov 20, 2019
6 checks passed
6 checks passed
Header rules No header rules processed
Details
Pages changed 4 new files uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@quincylvania quincylvania added this to the 2.16.1 milestone Nov 20, 2019
quincylvania added a commit that referenced this pull request Nov 20, 2019
Add endpoint to actionSplit to get the created ways after running the action
Change "Use bridge" or "tunnel" fix labels to "Add a bridge" or "tunnel"
Add layer tags on structure feature when adding a bridge or tunnel via a fix
Select all components of the split way when adding a bridge or tunnel via a fix
Don't recommend adding a bridge to a waterway
Don't show "change layers" fixes along with "add structure" fixes
Don't split or change the tags of coincident ways when adding a bridge or tunnel
@quincylvania

This comment has been minimized.

Copy link
Collaborator

quincylvania commented Nov 20, 2019

Hi @CarycaKatarzyna! Thanks so much for this, it looks really great. I merged it as-is and then followed up with a few tweaks.

quincylvania added a commit that referenced this pull request Nov 20, 2019
… is too short to add a new vertex (re: #7055)

Avoid creating very short edges from splitting too close to another node when adding a bridge or tunnel via fix
Fix possible "entity not found" error
@quincylvania

This comment has been minimized.

Copy link
Collaborator

quincylvania commented Nov 20, 2019

Here's a screencapture. I think this feature will be really helpful and will hopefully reduce instances where mappers erroneously select the connection fix since it was the easiest.

add structure fix demo

@bhousel

This comment has been minimized.

Copy link
Member

bhousel commented Nov 20, 2019

So awesome 🎉
I've wanted this for a while...

quincylvania added a commit that referenced this pull request Nov 20, 2019
Add a minimum structure length as derived from the crossing feature's width
@CarycaKatarzyna CarycaKatarzyna deleted the CarycaKatarzyna:fix-issue-6617 branch Nov 22, 2019
@tordans

This comment has been minimized.

Copy link
Contributor

tordans commented Dec 24, 2019

Awesome, this is perfect for the way I map. Thanks!

@matkoniecz

This comment has been minimized.

Copy link
Contributor

matkoniecz commented Jan 3, 2020

One more thank you, this is something really useful! It is nice to see iD editing getting easier.

I am now adding missing bridges/tunnels (more than 300 cases of broken data, in Rymanów and in Beijing), I was not expecting that iD has a chance to be better than JOSM for this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.