New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support addr:place addresses #353
Comments
|
There should be a drop-down menu where you can choose an address format valid for the region/BBOX. Something like: Select an address format:
* -- adds |
|
I would definitely like to improve this! It will however require a delicate approach since addresses are quite a complex matter… Btw, I had proposed this one myself back in 2014 in openstreetmap/iD#2246 (comment) |
A warning: a lot of the use is incorrect. In the UK we worked out that at least 80% of the addr:place data was wrong. A tag like addr:suburb should have been used instead! Nomination Data Analyser shows incorrect cases where addr:place and addr:street have been used on the same feature. Having cleaned up a lot of the incorrect uses in the UK, and followed lengthy discussions on talk-GB, I found the following issues:
I love the use of the word "quite" in there. So polite and almost downplays the issue. Addressees are hugely complex in the style and variety across different countries. Whatever solution is build for this, it will certainly need to be adaptable depending on which country you are mapping in. |
|
As seen in the screenshot in #353 (comment), the Address field is already capable of being laid out like a printed address on an envelope. It also varies by country. What isn’t currently supported is a mechanism for toggling between different formats relevant within a single country or conditionally showing one textbox based on another textbox being filled in. This capability would be useful regardless of |
Have you already reported this issue to JOSM developers? (or is there an open issue created by someone else?) |
I hadn't seen this as an envelope but I had realised the positioning was done to aid mappers. And I agree, it is all the bits that are missing that add complexity. For example in the UK one line of the address would be addr:housenumber + " " + addr:street. But if you add a addr:place tag then it becomes two lines showing addr:housenumber + " " + addr:place on one line, with addr:parentstreet on the second (yes, we have an addr:parentstreet tag in the UK because some addressees have a child+parent relationship type concept here).
|
|
What would need to be implemented in order to make this happen? The two situations I can imagine are one where you select a format for a country, or one where you can just add more fields to it like [+] Block Number and so on. I'm curious because I've noticed recently how often addresses get mapped with things that are not street names in the street name field. It seems like something flexible that doesn't assume too much about what sort of addresses a user is mapping would be the simplest. Not everywhere even has a ruleset about what what addresses should look like, so I think options like "urban address" and "village" address could potentially complicate things when the user likely knows which fields are relevant and which aren't as long as they're all options. Otherwise you could end up trying to account for things like "gas station in the Himalayas" address (usually has a milestone address) or "houseboat address" (might have a marina name in it as addr:place) and so on. |
|
is it possible to at least show addr:place if set ? this would avoid users filling addr:street because it is empty |
This is what I used to think too but not anymore. This year we had a very long discussion with the UK community and learnt about the history of addr:place (the tag didn't originate from the UK mapping community). It is for use when there is no addr:street. So certainly in many communities the validation rule proposed should be implemented. As for the address example above, I'm not familiar with addresses in Bulgaria. We decided to respect the original intent of addr:place and not use it with addr:street. Through discussion we came up with other solutions. Should you wish to do the same then community discussion is the way forward. Of course if the local community is aware of this and has decided to use addr:place anyway, then fine but that shouldn't stop validation checks flagging it for most other countries. For more details see the conclusions of the UK discussion here: https://wiki.openstreetmap.org/wiki/Addresses_in_the_United_Kingdom |
I agree with you. Such cases are an exception to the rule. I think we already disscused it in the community and found some solution but I can't find the thread right now. |
|
This double addressing system is wide-spread in areas of the former Austria-Hungarian empire. (I presume that this is what @Dimitar5555 refers to although it is hard to say without knowing where the example comes from.) It is usually tagged in OSM using |
|
@lonvia it's a Soviet era panel building. |


is a valid tagging, in widespread use, not supported by iD
When used iD encourages to add not actually missing data. Especially "City" field is a nasty trap.
Ideally it would be shown as "Address without street name" or something, at least when tagged already
https://taginfo.openstreetmap.org/keys/addr%3Aplace
https://wiki.openstreetmap.org/wiki/Key%3Aaddr%3Aplace
See also openstreetmap/iD#2898
Triggered by https://forum.openstreetmap.org/viewtopic.php?pid=851946#p851946 where user was confused by not displayed addresses
//edit @tyrasd: I've removed a part of the original title, because it was a bit long. It used to include the following information: […] (over 9 000 000 uses, widespread addressing schema, iD interface encourages to break addressing data)
The text was updated successfully, but these errors were encountered: