FIX: HTTP Header: use numeric portnumber for Host

[mmd-osm]

This patch fixes an issue on a really ancient Merkaartor release - namely an incorrect HTTP Header field "Host". For years this was not an issue, but due to recent changes on the Apache configuration, the Hostname is now checked on the server and a HTTP 301 redirect returned. The old Merkaartor version however has no way to deal with this situation and has become more or less useless.

Please see openstreetmap/openstreetmap-website#1407 for details.

I don't know, if it makes sense to release a 0.17.3 for Windows - that would be needed for users unable to migrate to 0.18. Please don't ask me why they can't upgrade, I asked the user but didn't get a conclusive answer.

[Krakonos]

Thanks. I have merged this changed into 0.17-fixes, but will not do a release for it, unless a very good reason is found.

The main reason is I don't have a build environment for Windows, and I'm not sure if it even builds on recent linux releases.

I am however open to fixing issues that prevent users from migrating to a new version.

[mmd-osm]

Thanks a lot for the quick merge.

Even though the 0.17 branch is quite dated, I could still compile it on Ubuntu 16.04 with various qt4 libs installed and some explicit switches to qt4 (QT_SELECT=qt4 qmake). Also, gcc 4.6 was needed to compile (make CXX=g++-4.6), as newer gcc versions produced some error message which I don't recall.

If the previous build chain for Windows is no longer available, I would not spend a single minute trying to get it to work again. That would be a complete waste of time.

I will see if I can get some more details as to why the upgrade did not work for that particular user. He mentioned something like the version is crashing immediately after the start, but that's about all I know. No details about Windows version, Hardware or anything else which may be relevant.

[stephan75]

@Krakonos ... you wrote about no windows build environment available for you now ...

maybe the service of AppVeyor can be helpful then? ... usable for free to opensource projects?

See https://blog.cihar.com/archives/2017/01/04/seven-tools-help-us-develop-weblate/ where I found that hint.

[Krakonos]

@mmd-osm Yes, qt4 and gcc 4.x should be fine. Please, do let me know if you find some details, as I'd rather fix current issues than work on the old ones. The windows toolchain is non-existent, macos the same, and Linux maintainers will merge the patch if they care about the old version. I don't think I can do anything better now.

I'm closing the issue now, please make a new one if you find out more about the 0.18.3 bug.

@stephan75 Thanks! I actually have windows build environment for the current releases, but don't have the old one. When I took over the project, I had to make the environment from scratch, as I didn't have any information about the previous one and based on my experience, it was probably fiddley.

I'm currently able to build under MSYS2, and releases are done in that way. It's pretty convenient, documented in the INSTALL.md and works even in Wine! There are also a tea-ci.org, that does automatic building and uploads an installer for each commit that successfully builds.

[KrilleGH]

Thank you very much for the fix. I just ran into this issue. For certain reasons I can't update as well at the moment but the fix makes it work again.