Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up to #190 for render_list #417

Merged
merged 5 commits into from
Mar 21, 2024
Merged

Conversation

hummeltech
Copy link
Collaborator

@hummeltech hummeltech commented Mar 21, 2024

  • Fixed render_list build needs libm
  • Added tests
  • Updated man page
  • Created function to set double
  • Cleaned up / optimized a bit
  • Removed --dont-render option


{"help", no_argument, 0, 'h'},
{"version", no_argument, 0, 'V'},
{0, 0, 0, 0}
};

int c = getopt_long(argc, argv, "ac:fm:l:X:Y:Z:x:y:z:n:s:t:vhVdA:B:C:D:", long_options, &option_index);
int c = getopt_long(argc, argv, "ac:fm:G:l:W:X:Y:Z:g:w:x:y:z:n:s:t:vhV", long_options, &option_index);

Check warning

Code scanning / Flawfinder

Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Warning

buffer/getopt_long:Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20).
@@ -287,6 +284,10 @@
fprintf(stderr, "\n");
fprintf(stderr, "If you are using --all, you can restrict the tile range by adding these options:\n");
fprintf(stderr, "(please note that tile coordinates must be positive integers and are not latitude and longitude values)\n");
fprintf(stderr, " -G, --max-lat=LATITUDE maximum latitude\n");

Check notice

Code scanning / Flawfinder

If format strings can be influenced by an attacker, they can be exploited (CWE-134). Note

format/fprintf:If format strings can be influenced by an attacker, they can be exploited (CWE-134).
@@ -287,6 +284,10 @@
fprintf(stderr, "\n");
fprintf(stderr, "If you are using --all, you can restrict the tile range by adding these options:\n");
fprintf(stderr, "(please note that tile coordinates must be positive integers and are not latitude and longitude values)\n");
fprintf(stderr, " -G, --max-lat=LATITUDE maximum latitude\n");
fprintf(stderr, " -g, --min-lat=LATITUDE minimum latitude\n");

Check notice

Code scanning / Flawfinder

If format strings can be influenced by an attacker, they can be exploited (CWE-134). Note

format/fprintf:If format strings can be influenced by an attacker, they can be exploited (CWE-134).
@@ -287,6 +284,10 @@
fprintf(stderr, "\n");
fprintf(stderr, "If you are using --all, you can restrict the tile range by adding these options:\n");
fprintf(stderr, "(please note that tile coordinates must be positive integers and are not latitude and longitude values)\n");
fprintf(stderr, " -G, --max-lat=LATITUDE maximum latitude\n");
fprintf(stderr, " -g, --min-lat=LATITUDE minimum latitude\n");
fprintf(stderr, " -W, --max-lon=LONGITUDE maximum longitude\n");

Check notice

Code scanning / Flawfinder

If format strings can be influenced by an attacker, they can be exploited (CWE-134). Note

format/fprintf:If format strings can be influenced by an attacker, they can be exploited (CWE-134).
fprintf(stderr, " -G, --max-lat=LATITUDE maximum latitude\n");
fprintf(stderr, " -g, --min-lat=LATITUDE minimum latitude\n");
fprintf(stderr, " -W, --max-lon=LONGITUDE maximum longitude\n");
fprintf(stderr, " -w, --min-lon=LONGITUDE minimum longitude\n");

Check notice

Code scanning / Flawfinder

If format strings can be influenced by an attacker, they can be exploited (CWE-134). Note

format/fprintf:If format strings can be influenced by an attacker, they can be exploited (CWE-134).
@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 97.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 64.66%. Comparing base (2a4532f) to head (d3a11e9).
Report is 1 commits behind head on master.

Files Patch % Lines
src/renderd_config.c 83.33% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #417       +/-   ##
===========================================
- Coverage   79.44%   64.66%   -14.78%     
===========================================
  Files          24       24               
  Lines        5848     4367     -1481     
===========================================
- Hits         4646     2824     -1822     
- Misses       1202     1543      +341     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hummeltech hummeltech merged commit 743cf65 into openstreetmap:master Mar 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants