Skip to content

Commit

Permalink
Default background for input fields to white
Browse files Browse the repository at this point in the history 
Some browsers apparently default form fields to a background based
on the desktop theme, and don't inherit from body.

Fixes #883
  • Loading branch information
@tomhughes
tomhughes committed Feb 1, 2015
1 parent 2f6f627 commit d423ae9
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions app/assets/stylesheets/common.css.scss
View file
Expand Up @@ -1871,6 +1871,7 @@ input[type="email"],
input[type="url"],
input[type="password"],
textarea {
background-color: #fff;
border: 1px solid #ccc;
padding: 2px 5px;
margin: 0;
Expand Down

3 comments on commit d423ae9

@ximex
Copy link

@ximex ximex commented on d423ae9 Feb 1, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the "select" element is missing and the "color" should be set too

@tomhughes
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed the foreground colour in 6f762ae but I don't think we can do select - our design (or perhaps lack-of-design) for select at the moment is essentially to use the browser default styling. So any attempt to fix it for your dark theme would result in a change of style for everybody.

@ximex
Copy link

@ximex ximex commented on d423ae9 Feb 1, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here 3 pics how it looks now (much better!):
osm_searchbox
osm_left
osm_right

Is it normal that is very hard to read the text in the button to send the node under the textbox?

Please sign in to comment.