Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Troubles during routing / unnecessary frontend geocoding #1053

Open
d1g opened this issue Sep 11, 2015 · 7 comments
Open

Troubles during routing / unnecessary frontend geocoding #1053

d1g opened this issue Sep 11, 2015 · 7 comments

Comments

@d1g
Copy link

d1g commented Sep 11, 2015

User was unable to search route

from 56.785591,52.858237
to 56.7821,52.8641

using openstreetmap.org interface while custom URL and external services work fine

@d1g d1g changed the title Troubles during routing Troubles during routing / unnecessary frontend geocoding Sep 11, 2015
@tomhughes
Copy link
Member

Pointing me at something in russian doesn't really help much. In general bug reports should stand alone rather than just pointing at an external resource and that goes double if the external source is in a different language...

Can you explain what exactly is the problem the user encountered when trying to make that route?

@tomhughes
Copy link
Member

Hmm I see you've already edited it to explain a bit more clearly, but it's still quite vague.

@tomhughes
Copy link
Member

Certainly just saying "incorrect URL" doesn't tell us much - you need to explain what is "wrong" about it.

To be honest I suspect the issue is just that we are snapping lat/lon values to geocodes.

@d1g
Copy link
Author

d1g commented Sep 11, 2015

Starting and ending position was incorrectly/unnecessary geocoded as "Подшиваловское сельское поселение, Завьяловский район, Удмуртская Республика, Приволжский федеральный округ, Российская Федерация" (by nominatim?)

We don't need geocoding when we search by exact coords.

@d1g
Copy link
Author

d1g commented Sep 11, 2015

@tomhughes problem is that two distinct points can be geocoded as same point (incorrect URL #1 or #2). While such simplification may be reasonable for car routers. This is wrong for pedestrian routers since user want his starting and end point treated as "exact coords".

Probably we want to disable geocoding for pedestrian routes or add check box to disable geocoding of coordinates.

Does use case and problem more clear now?

@tomhughes
Copy link
Member

In understand the problem, but it's not trivial to fix I suspect because that geocoding is done client side. If it went through our normal search interface then coordinates would automatically be special cased.

@karussell
Copy link
Contributor

We don't need geocoding when we search by exact coords.

The reverse geocoding is useful to know the name but it should not change the original geocodes. For GraphHopper Maps there was code (currently disabled) which did the same and showed the location name under the input box but preserved the geocodes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants