Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow-up #1400 #1407

Closed
mmd-osm opened this issue Jan 6, 2017 · 1 comment
Closed

Follow-up #1400 #1407

mmd-osm opened this issue Jan 6, 2017 · 1 comment

Comments

@mmd-osm
Copy link
Contributor

mmd-osm commented Jan 6, 2017 •
edited

Apologies for creating a new issue for this stuff, but #1400 is locked unfortunately and I just wanted to add a two line comment. So here we go:

I could reproduce the issue locally on a fresh Merkaartor 0.17.2 build. The API URL as it is maintained in Merkaartor is perfectly ok, but somehow Merkaartor screwed up the "Host" part in the HTTP request header by adding ":P" instead of ":80". (80 actually corresponds to ascii P).

This strict host check along with HTTP 301 redirect seems to be somehow related to #1400, or maybe user:wycbtma didn't use Merkaartor for some time and only noticed the effect now. I don't know if you want to support such a crappy and old client. At least the user who reported it (and somehow is unable to upgrade for whatever reason) can no longer use his Merkaartor version.

See this HTTP trace I collected in wireshark:

GET /api/0.6/way/65190596/relations HTTP/1.1
Host: www.openstreetmap.org:P
User-Agent: Merkaartor/0.17 (X11;SVNREV)
Authorization: Basic Og==
content-length: 0

HTTP/1.1 301 Moved Permanently
Date: Fri, 06 Jan 2017 17:39:15 GMT
Server: Apache/2.4.18 (Ubuntu)
Location: http://www.openstreetmap.org/api/0.6/way/65190596/relations
Content-Length: 356
Content-Type: text/html; charset=iso-8859-1

<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>301 Moved Permanently</title>
</head><body>
<h1>Moved Permanently</h1>
<p>The document has moved <a href="http://www.openstreetmap.org/api/0.6/way/65190596/relations">here</a>.</p>
<hr>
<address>Apache/2.4.18 (Ubuntu) Server at www.openstreetmap.org:p Port 80</address>
</body></html>
@tomhughes
Copy link
Member

So as I said all along the client is broken and there's no bug here.

@mmd-osm mmd-osm mentioned this issue Jan 7, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomhughes @mmd-osm