Multiple link colors #183

Open
ppawel opened this Issue Jan 16, 2013 · 16 comments

Comments

Projects
None yet
4 participants
Contributor

ppawel commented Jan 16, 2013

Not sure if this is intentional but it looks a bit strange that some links have different coloring (BTW, I think we should keep the paler blue).

Owner

tomhughes commented Jan 16, 2013

Well those links are part of "deemphasized" text, so the text is grey and the links are also paler.

Contributor

ppawel commented Jan 16, 2013

Hmm, then I guess the "Latest edit..." text and links within should also be "deemphasized" if we want to keep this distinction.

The same thing is in search results where if anything the results should be emphasized... Right now "Results from OpenStreetMap Nominatim" and other headers pop up while this information is not really relevant to the user (or at least not as much as search results themselves).

Owner

tomhughes commented Jan 16, 2013

Well I think the idea is that the key text is left as it is and the less important things are deemphasized - just deemphasizing the whole thing kind of defeats that!

Of course you may agree with @samanpwbb about what exactly is "key" in that list ;-)

Contributor

ppawel commented Jan 16, 2013

In any case to me it looks very strange and rather like a CSS bug or maybe like those paler links have been marked as visited.

Perhaps @samanpwbb can explain more. If this is intentional and you want to leave it as is then OK but it still looks very unusual...

Member

samanpwbb commented Jan 16, 2013

@tomhughes how would you feel about moving all the links, including inline links, to green? I'm interested in the OSM brand kind of 'owning' a particular highlight color and a nice mappy green could work.

Owner

tomhughes commented Jan 16, 2013

It's not really my decision to make any more than anybody else - what do people in general think about using a different link colour?

Contributor

ppawel commented Jan 16, 2013

+1 to changing the current in-your-face blue to something else (like the paler blue). It can be green if it fits (@samanpwbb - can you provide some preview screenshots?).

Member

samanpwbb commented Jan 16, 2013

I played around with changing the color scheme to green and it's a little weird ( http://cl.ly/image/1b3i3n0n1i1n ). Leaving things as is for now. Currently, there's a primary link color (dark blue) and a deemphasized link color (light blue). I think this works fine. The alternative would be to use the same link color for both types and differentiate with a change in font size.

Contributor

ppawel commented Jan 16, 2013

I did a quick experiment with the same link color for both link types:

image

The color is a darker version of the pale blue: #2042aa.

I think it looks much better this way than two different colors, especially two shades of blue...

PS. I think the fact that the "Edit this entry" action is in the new line is a bug?

Owner

tomhughes commented Jan 16, 2013

I don't see the new line there? Well unless I make my window so narrow it has to split the line...

Contributor

ppawel commented Jan 16, 2013

@tomhughes Are you looking at your own posts? It only happens with the "edit this entry" action which I guess only is available on user's own diary listing. Perhaps this is caused by one of the li elements being wrapped in a span?

Removing "display: inline-block;" from ".diary_post ul.secondary-actions" class fixes this for me.

Owner

tomhughes commented Jan 16, 2013

Yes I was looking at my own entry... I suspect you are right about the span though - presumably that is causing your browser to move that li into a new list? Firefox is keeping it all in the one list as intended.

Contributor

ppawel commented Jan 16, 2013

I'm on Chromium 24.0.1312.52 (175374). Opened #188 for that.

Owner

tomhughes commented Jan 16, 2013

I've pushed a fix in 4b9efb6 to avoid nesting an li in a span.

emacsen commented Dec 6, 2013

Is this fixed, perhaps in the redesign, and thus this issue can be closed?

Owner

tomhughes commented Dec 6, 2013

Nothing here has changed as far as i can see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment