Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow sorting and filtering of notes displayed in user profile #832

Open
rudolfmayer opened this issue Nov 7, 2014 · 15 comments
Open

Allow sorting and filtering of notes displayed in user profile #832

rudolfmayer opened this issue Nov 7, 2014 · 15 comments
Labels
enhancement notes ui

Comments

@rudolfmayer
Copy link

@rudolfmayer rudolfmayer commented Nov 7, 2014

Not sure if this was already reported in some way, at least I couldn't find anything in the open issues.

My request is as follows - the user page displaying the notes created, e.g. mine at http://www.openstreetmap.org/user/Rudolf%20Mayer/notes, should allow for

  • sorting by creation date, solved date, name, ...
  • filtering; here especially I would like to be able to display only the unresolved notes, as these are the ones I'd like to work on improving.

Thanks for your consideration,
Rudolf

@mattflaschen
Copy link

@mattflaschen mattflaschen commented Nov 27, 2014

I would also appreciate being able to filter to show only notes I created.

As is, there is no way to do so, which means notes you triage or comment on become commingled into one large list.

@mnalis
Copy link

@mnalis mnalis commented Jan 20, 2015

I absolutely agree, especially on filtering by unresolved notes.

I've dozen of "my notes" pages, and if a note ever need work that I cannot do immediately (eg. it need resurveying), it will fall behind first few pages and with current situation I'll likely never see (and hence will not give attention to) that note again...

Or at least, firstly show all unresolved notes, and only after them all resolved notes. That one should literally be single line change in the code (modifying ORDER BY clause) so extremely easy to do, should not stop on anybody toes, and would increase functionality a lot.

@mnalis
Copy link

@mnalis mnalis commented Feb 4, 2015

since I couldn't wait for this to be implemented, as a temporary workaround I made it myself:
http://my-notes.osm-hr.org/
( or go grab the source yourself at https://github.com/osm-hr/my-osm-notes )

You can specify one (or several) users, and it will show only unresolved notes that they created or participated in (commented, closed, reopened etc). It uses Notes planet dump, so only gets updated once a day. Real solution in openstreetmap website would be much better (and operate in realtime), so hopefully this ticket would get some attention. Until it does, you're welcome to use instance above.

@mnalis
Copy link

@mnalis mnalis commented Feb 18, 2015

@gravitystorm gravitystorm added enhancement notes ui labels Apr 28, 2021
@letypequividelespoubelles

any developement coming sson ? It seems it's an expected feature !

@gravitystorm
Copy link
Collaborator

@gravitystorm gravitystorm commented Apr 28, 2021

any developement coming sson ? It seems it's an expected feature !

Volunteers welcome! Otherwise, it's like many other features and is waiting in the list.

@letypequividelespoubelles

@gravitystorm :) Unfortunetaly I don't have the dev skills :(

@mnalis

This comment has been minimized.

@tomhughes
Copy link
Member

@tomhughes tomhughes commented Apr 28, 2021

Well those PRs are to a different project and being dealt with by a different person that doesn't even have commit here so I'm not sure there is any relation to this?

@rudolfmayer
Copy link
Author

@rudolfmayer rudolfmayer commented Apr 28, 2021

I do see the relation quite clearly - @mnalis has had bad experiences with a project that is yes, not this one, but in some way related to this one; that's why he asked directly here: if he implements this, will it be accepted, resp. maybe more general, will he at least get feedback.
I think that is a very direct question to the repo owners, and a direct answer would be welcomed.

(I would be very thankful to @mnalis for implementing my feature request, but well, I can't do anything about the PR...)

@gravitystorm
Copy link
Collaborator

@gravitystorm gravitystorm commented Apr 29, 2021

I really want to make very sure I won't be wasting a lot of my time and effort if I decide to try to tackle this one...

It's impossible for me to make any guarantees, since I'm only a volunteer here. I can't predict the future (e.g. if I'll be available if/when you make a pull request) and my available time is limited anyway. So my recommendation is to look at our previous performance and estimate based on that. Most PRs get a review reasonably quickly, but I can only review about 1-3 PRs per week (remember I'm a volunteer too so my time is limited) so some PRs wait for a few weeks before being reviewed. And there are definitely some that take much longer to be dealt with, though they are often more about policy changes than simple code changes. But that's only 35 out of the nearly 1500 PRs so far, so you can see most are dealt with in reasonable time.

If you are worried that it might be a lot of effort for just one PR, then I would encourage you to aim to make multiple PRs! That way the learning of the codebase will be more worthwhile. Remember there are hundreds of thousands of mappers using the website every week, so even small improvements can have a big impact.

But like all volunteering, you put in the effort in the hope it will be useful, not with any guarantees.

@mnalis

This comment has been minimized.

@mnalis
Copy link

@mnalis mnalis commented Apr 29, 2021

As I see this issue, one of the main problems seem to be that open and closed noted are all shown mixed together, while people are usually mostly interested in open (unresolved) notes.

So what I'd like to try to implement as a first PR here, is change the default sort of Notes to firstly show all open notes (sorted by last change date) followed by all closed notes (also sorted by last change date), as opposed to the current situation (where all notes are sorted only by last changed date, intermixing open and closed notes).
While this first PR would not implement all requested ideas, it would solve one of most pressing issues (putting best visibility on open notes), while not greatly impacting all other users who are used to old behavior.

Does this sound reasonable, and would you @gravitystorm accept such PR?

It that is accepted and goes well, I'd later try to design and implement more complex parts of this request - after first checking in this ticket if committers would find such a design good, of course.

I've also indicated interest in few other issues in this repo as you suggested, so as soon as you (or some other committer) agree that they think it is a good idea, I'll try to work on those PRs too.

@tomhughes
Copy link
Member

@tomhughes tomhughes commented Apr 29, 2021

Well it will either be @gravitystorm or me here, while you're dealing with @Firefishy (who is away this week) on those chef issues.

@mnalis
Copy link

@mnalis mnalis commented May 25, 2021

Would either of @gravitystorm or @tomhughes accept a pull request which changes sort order so first all open notes are displayed (followed by all closed notes) as explained in #832 (comment)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement notes ui
Projects
None yet
Development

No branches or pull requests

6 participants