Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed-Codes lack proper attribution #838

Closed
stkdiretto opened this issue Nov 17, 2014 · 2 comments
Closed

Embed-Codes lack proper attribution #838

stkdiretto opened this issue Nov 17, 2014 · 2 comments

Comments

@stkdiretto
Copy link

I was made aware by an OSM contributor that an embedded Transport map was lacking the proper attribution (“© OpenStreetMap contributors”) and only showed the “Tiles courtesy of Andy Allan” notice in the lower right corner.

As it turns out, the error appears to lie within the official embedding code I pulled from the official OSM site. The large map view shows the proper attribution, but the embedded IFrame doesn't.

Since I assume OSM is supposed to make re-using the maps as user-friendly as possible, I'd wager the attribution should be part of the embedded version, too, without requiring users to tweak it as to properly display the attribution information ;)

@tomhughes
Copy link
Member

The embedded maps just use the default attributions from https://github.com/jfirebaugh/leaflet-osm/blob/master/leaflet-osm.js so any fix needs to be applied there - the large map has local customisations.

@tomhughes
Copy link
Member

Looks like this was fixed upstream in openstreetmap/leaflet-osm@ef00c02 and we need to update our copy.

@tomhughes tomhughes reopened this Nov 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants