Simplify new-note marker placement - always in the centre #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(This removes a tweak added in 40b3c82, which we believe is no longer relevant now the new-note dialogue is sidebar rather than bubble.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a tweak added in 40b3c82, which we believe is no longer relevant now the new-note dialogue is sidebar rather than bubble.
I've tested this with various screen sizes (inc mobile-sized) on my laptop with Firefox and Chromium. It looks good and doesn't incur scrolling (as the comment on 40b3c82 might suggest).
Fixes #1028