Skip to content

Avoid double-escaping diary entry titles #1348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2016
Merged

Avoid double-escaping diary entry titles #1348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/views/diary_entry/rss.rss.builder
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ xml.rss("version" => "2.0",

@entries.each do |entry|
xml.item do
xml.title h(entry.title)
xml.title entry.title
xml.link url_for(:action => "view", :id => entry.id, :display_name => entry.user.display_name, :host => SERVER_URL)
xml.guid url_for(:action => "view", :id => entry.id, :display_name => entry.user.display_name, :host => SERVER_URL)
xml.description entry.body.to_html
Expand Down
7 changes: 7 additions & 0 deletions test/controllers/diary_entry_controller_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,6 +563,13 @@ def test_rss_nonexisting_user
assert_response :not_found, "Should not be able to get a deleted users diary RSS"
end

def test_rss_character_escaping
create(:diary_entry, :title => "<script>")
get :rss, :format => :rss

assert_match "<title>&lt;script&gt;</title>", response.body
end

def test_view
# Try a normal entry that should work
diary_entry = create(:diary_entry, :user => users(:normal_user))
Expand Down