New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include car profile for GraphHopper routing #1547

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@karussell
Contributor

karussell commented May 22, 2017

We now have a fast routing that is able to consider turn restrictions (and costs). And so we would like to add car as a further option.

@@ -79,5 +80,6 @@ function GraphHopperEngine(id, vehicleType) {
};
}
OSM.Directions.addEngine(new GraphHopperEngine("graphhopper_bicycle", "bike"), true);
OSM.Directions.addEngine(new GraphHopperEngine("graphhopper_foot", "foot"), true);
OSM.Directions.addEngine(new GraphHopperEngine("graphhopper_car", "car", true), true);

This comment has been minimized.

@tomhughes

tomhughes May 22, 2017

Member

I assume that disableCH refers to contraction hierarchies, in which case I would have thought long distance car routing would be exactly the case where you would want them so I'm surprised that you are disabling them for car routing but leaving them enabled for other things?

@tomhughes

tomhughes May 22, 2017

Member

I assume that disableCH refers to contraction hierarchies, in which case I would have thought long distance car routing would be exactly the case where you would want them so I'm surprised that you are disabling them for car routing but leaving them enabled for other things?

This comment has been minimized.

@karussell

karussell May 22, 2017

Contributor

We disable contraction hierarchies for car as we currently have not implemented CH with turn restrictions. But disabling CH now falls back to a still fast enough algorithm that supports turn restrictions. For the others vehicle profiles: there is no reason yet to not use CH.

@karussell

karussell May 22, 2017

Contributor

We disable contraction hierarchies for car as we currently have not implemented CH with turn restrictions. But disabling CH now falls back to a still fast enough algorithm that supports turn restrictions. For the others vehicle profiles: there is no reason yet to not use CH.

This comment has been minimized.

@tomhughes

tomhughes May 24, 2017

Member

Well I would have thought that if needed to be disabled for the car profile then that should be something the server did automatically as part of the profile rather than forcing the client to deal with implementation details...

@tomhughes

tomhughes May 24, 2017

Member

Well I would have thought that if needed to be disabled for the car profile then that should be something the server did automatically as part of the profile rather than forcing the client to deal with implementation details...

This comment has been minimized.

@karussell

karussell May 24, 2017

Contributor

This is true but we have to enable CH for backward compatibility reasons for now

@karussell

karussell May 24, 2017

Contributor

This is true but we have to enable CH for backward compatibility reasons for now

@tomhughes tomhughes closed this in 0531091 May 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment