Fixed on ramps and off ramps leading onto unnamed roads #1740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- On and off ramps now reference the direction that the ramp is heading in. - i.e. the directions text now says 'Take the ramp on the left towards Baltimore, I58' instead of 'Take the ramp on the left onto unnamed road'
jguthrie100
force-pushed
the
iss1573
branch
2 times, most recently
from
0ed8b4a
to
3078ff0
Compare
|
The Matches the OSRM site more closely |
jguthrie100
force-pushed
the
iss1573
branch
2 times, most recently
from
c615185
to
4afdb53
Compare
|
If I'm understanding this right then this doesn't actually limit itself to unnamed roads right? It changes all on and off ramps to be described in terms of the destination (if any) and not to mention the road you are moving on to? Wouldn't it be better to show both if they are known? or at least to show the road name if that is known and the destination isn't? |
|
Yeah that makes more sense. Is there any chance you could have a look at #1741 , because when/if that gets committed, it'll change the logic required for checking whether an off/onramp has a valid name.. |
jguthrie100
force-pushed
the
iss1573
branch
2 times, most recently
from
d8ba01e
to
74e3ba1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1573
The directions text on on and off ramps now says (for eg) 'Take the ramp on the left towards Baltimore, I58' instead of 'Take the ramp on the left onto unnamed road'
Tested on motorways/highways across USA and Europe