Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Adding ability to add a website to user profile #198

Open
wants to merge 2 commits into
from

Conversation

Projects
None yet
5 participants

A wide variety of other websites allow users to link back to their website. OpenStreetMap contributors often have their own blogs. Allowing them to link to them helps verify their identity and improve the trust others place in them.

adding ability to add website to profile
uses the rel=me microformat

cbetta commented Jan 20, 2013

Shouldn't url be added to the attr_accessible list or this to work?

@cbetta cbetta commented on the diff Jan 20, 2013

db/migrate/20121202163003_add_url_to_user_model.rb
@@ -0,0 +1,5 @@
+class AddUrlToUserModel < ActiveRecord::Migration
+ def change
+ add_column :users, :url, :string
@cbetta

cbetta Jan 20, 2013

If you are going to insist on :string, better make the validator check the length then.

Contributor

woodpeck commented Jan 20, 2013

If we want to allow such URLs then I don't think we should limit to one; some people have a blog and a facebook page, others have a personal website and a G+ page, and so on. AFAIK it was possible to add arbitrary links to your profile text in the past but at some point we removed them to be less interesting to spammers.

So the real issue here is not adding one single URL to the model (which would only re-introduce the spam problem), but to deal with the spam problem properly (and if that's done, one could just allow arbitrary links in the profile text again).

Owner

tomhughes commented Jan 20, 2013

Firstly @woodpeck is right that this shouldn't be limited to a single link.

Secondly, he's completely wrong about not being able to add links to your description - it's perfectly possible and lots of people do it.

One way to potentially solve the spam problem is to not show any links in the person's profile until they've made x number of changesets... but that's rather outside of the remit of this patch...

cbetta commented Jan 20, 2013

I don't see why people would have to list > 1 site. If you want to list > 1 site, please do so on your own site tbh.

Contributor

woodpeck commented Jan 20, 2013

Hee hee... I tested it with an "a href" HTML style link instead of markdown that's why I assumed it wouldn't work any more. Of course TomH is right and you can have any number of links in your profile, e.g. http://www.openstreetmap.org/user/TomH.

Contributor

Zverik commented Jan 21, 2013

I'm sorry, but isn't it already possible with user descriprion? That's where most users put their links, me included. Some even have rather big link archive there, like az09.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment