Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upUse deliver_later for email sending #2038
Conversation
gravitystorm
added
work-in-progress
and removed
work-in-progress
labels
Oct 31, 2018
gravitystorm
changed the title from
[WIP] Use deliver_later for email sending
to
Use deliver_later for email sending
Nov 2, 2018
This comment has been minimized.
This comment has been minimized.
|
Both the prerequisites have been finished, so this is ready to go. |
This comment has been minimized.
This comment has been minimized.
|
Looks reasonable but I'll want to be a bit careful deploying it so I can monitor things and make sure everything is working as expected... I'm wondering what to do about job queueing in development mode though - maybe use the inline adaptor so that things execute immediately without everybody having to run the daemon? |
tomhughes
merged commit b54362d
into
openstreetmap:master
Nov 3, 2018
gravitystorm
deleted the
gravitystorm:deliver_later
branch
Nov 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
gravitystorm commentedOct 31, 2018
•
edited
This PR builds on #2037 and configures email sending as a background task.
Note that this depends on having the setup for delayed_job (#2037) already merged, along with having workers running in production (openstreetmap/chef#201), before this can be deployed - so I'm marking it as WIP until those prerequisites are met.