Use deliver_later for email sending#2038
Merged
tomhughes merged 1 commit intoopenstreetmap:masterfrom Nov 3, 2018
Merged
Conversation
gravitystorm
changed the title
Collaborator
Author
|
Both the prerequisites have been finished, so this is ready to go. |
Member
|
Looks reasonable but I'll want to be a bit careful deploying it so I can monitor things and make sure everything is working as expected... I'm wondering what to do about job queueing in development mode though - maybe use the inline adaptor so that things execute immediately without everybody having to run the daemon? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on #2037 and configures email sending as a background task.
Note that this depends on having the setup for delayed_job (#2037) already merged, along with having workers running in production (openstreetmap/chef#201), before this can be deployed - so I'm marking it as WIP until those prerequisites are met.