New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use deliver_later for email sending #2038

Merged
merged 1 commit into from Nov 3, 2018

Conversation

Projects
None yet
2 participants
@gravitystorm
Collaborator

gravitystorm commented Oct 31, 2018

This PR builds on #2037 and configures email sending as a background task.

Note that this depends on having the setup for delayed_job (#2037) already merged, along with having workers running in production (openstreetmap/chef#201), before this can be deployed - so I'm marking it as WIP until those prerequisites are met.

@gravitystorm gravitystorm changed the title from [WIP] Use deliver_later for email sending to Use deliver_later for email sending Nov 2, 2018

@gravitystorm

This comment has been minimized.

Collaborator

gravitystorm commented Nov 2, 2018

Both the prerequisites have been finished, so this is ready to go.

@tomhughes

This comment has been minimized.

Member

tomhughes commented Nov 2, 2018

Looks reasonable but I'll want to be a bit careful deploying it so I can monitor things and make sure everything is working as expected...

I'm wondering what to do about job queueing in development mode though - maybe use the inline adaptor so that things execute immediately without everybody having to run the daemon?

@tomhughes tomhughes merged commit b54362d into openstreetmap:master Nov 3, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 84.941%
Details

@gravitystorm gravitystorm deleted the gravitystorm:deliver_later branch Nov 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment