Skip to content

Changeset list revamp #204

Closed
wants to merge 9 commits into from

4 participants

@samanpwbb
OpenStreetMap on GitHub member

This pull request reworks the changeset list page so the map is fixed and the changesets scroll alongside the map.

Here's a screenshot:
Screen Shot 2013-01-25 at 5 22 22 PM

Addresses issues brought up in #203

@tomhughes
OpenStreetMap on GitHub member

I've pushed this to http://tomh.apis.dev.openstreetmap.org/ for people to have a look at. I think the main thing I'm not sure about is the limiting of the heading to the left hand column, as it's not very consistent with all the other pages.

@samanpwbb
OpenStreetMap on GitHub member

@tomhughes I hear you! This is definitely a little disjointed right now, but I'd say a step in the right direction. In fact, I'd like to move some other pages closer to this, rather than the other way around. I like the idea of a significant map presence on more OSM pages: make the whole site feel like "panels on top of a map" rather than webpages with little map viewports every once in a while.

@lxbarth
lxbarth commented Feb 4, 2013

From staging I can't tell: is the map sticky now? The problem right now is that when I scroll down the changelist, I lose the map.

@samanpwbb
OpenStreetMap on GitHub member

@lxbarth it's a lot more like the owlviewer design I originally did. Basically, map is totally sticky and the changeset list is what scrolls.

@tomhughes
OpenStreetMap on GitHub member

I've added some more changesets on the staging instance now to make things a bit clearer.

@samanpwbb
OpenStreetMap on GitHub member

This is making me realize that the 'no changesets' state needs to be better, and needs to still show a map.

@jfirebaugh
OpenStreetMap on GitHub member

I think the main thing I'm not sure about is the limiting of the heading to the left hand column, as it's not very consistent with all the other pages.

What this could be consistent with is the look and feel of the "Data" and "Export" sidebars, which would make sense, as "History" appears to be another tab next to "Export" -- but currently behaves quite differently.

@samanpwbb samanpwbb referenced this pull request Jun 10, 2013
Closed

Fixed changeset map #298

@samanpwbb
OpenStreetMap on GitHub member

Replaced with #298

@samanpwbb samanpwbb closed this Jun 10, 2013
@samanpwbb samanpwbb referenced this pull request Jun 10, 2013
Closed

Fixed changeset map #299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.