New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First pass at diary mapping #219

Closed
wants to merge 0 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@mikelmaron
Copy link
Contributor

mikelmaron commented Mar 22, 2013

Pulls links to OSM objects out of diary body text, and builds up small map displaying features.
Screenshot from 2013-03-22 18:17:14

@tomhughes

This comment has been minimized.

Copy link
Member

tomhughes commented Mar 22, 2013

I guess the obvious question here is, what percentage of diary entries actually reference an object in this way? I'm guessing it is very few... After all it's not like it is something that is very easy to do.

@tomhughes

This comment has been minimized.

Copy link
Member

tomhughes commented Mar 22, 2013

There's also a lot of noise in this pull - it would be good to rebase the actual substantive edits on the current master branch.

@lxbarth

This comment has been minimized.

Copy link
Contributor

lxbarth commented Mar 22, 2013

@mikelmaron this is kinda cool. I also have user story questions. @tomhughes - could you stage this so we can play with it?

FWIW, I always wish I could drop in a slippy map by writing something like this

![](http://www.openstreetmap.org/?lat=10.47782&lon=-75.48961&zoom=16&layers=M)

"OpenStreetMap flavored markdown"?

@mikelmaron

This comment has been minimized.

Copy link
Contributor Author

mikelmaron commented Mar 23, 2013

Ooops, sorry about all those all old commits. I'll work on cleaning this up. mikelmaron@5be710c is the only relevant one.

After that, will look to get this up somewhere so we can all take a look at it running.

@mikelmaron

This comment has been minimized.

Copy link
Contributor Author

mikelmaron commented Mar 23, 2013

My intention is to add features that integrate the Diary more with OSM data and maps, make it more attractive to use. Right now there's not a lot of entries which use this construct, but there's not a lot of diary entries anyway, just under 19k. I've recently started using it more, and see good possibilities for constructive map socializing through the diary.

Like the map permalink example you gave @lxbarth, it works by simple cut-n-paste from node and way browse pages.

[](http://www.openstreetmap.org/browse/way/175643411)

The obvious next step is to add a map marker for the lat/lng of the diary entry itself. Scanning the text for permalinks would be simple to add as well.

@tomhughes

This comment has been minimized.

Copy link
Member

tomhughes commented Mar 24, 2013

I've merged this into http://tomh.apis.dev.openstreetmap.org/ now, though it seems to have a few issues:

http://tomh.apis.dev.openstreetmap.org/user/TomH/diary/5

The map is clearly not positioned right, but that may be an interaction with @samanpwbb's work on the diary which is also on that branch.

@openstreetmap-mirror openstreetmap-mirror force-pushed the openstreetmap:master branch from 068471f to d87ea68 Dec 19, 2014

@mikelmaron mikelmaron closed this Oct 20, 2015

@mikelmaron mikelmaron force-pushed the mikelmaron:master branch from 5be710c to 6078c3e Oct 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment