Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to iD v2.15.2 #2267

Merged
merged 2 commits into from Jun 20, 2019

Conversation

Projects
None yet
3 participants
@bhousel
Copy link
Member

commented Jun 17, 2019

Hello! We’ve heard plenty of feedback about the new validation capabilities in iD v2.15. We know that not everyone agrees that all the improvements we’ve made are helpful for OSM or in line with community tagging guidelines, so we’ve decided to roll back several of these recent controversial changes in this patch. Notably:

  • We removed the autofix option from the validator - users must now inspect and decide on each detected issue individually.
  • We removed the option to tag nonsquare buildings with a nonsquare=yes tag hint.
  • We adjusted the wording of the “upgrade tag” messages to use more neutral “nonstandard tag” language when updating branded features.
  • We fixed the bug that was causing the validator to add barrier=kerb when upgrading highway=crossing tags.
  • We changed the presets for piers and public transport platforms to no longer add highway=footway as a suggested tag.

We’re very sorry for the trouble that the recent iD update has caused, and we look forward to working with the OpenStreetMap community to make the map the highest quality that it can be.

Thanks, Bryan and Quincy
(@bhousel and @quincylvania)


2.15.2

2019-Jun-17

Usability

  • Prefer a Wikipedia commons logo over social media logo in some situations (#6361)

Validation

  • Remove issue "autofix" buttons
  • Don't suggest adding nonsquare=yes to physically unsquare buildings (#6332)
  • Stop suggesting adding highway=footway to piers, platforms, and tracks (#6229, #6409, #6042)
  • Fix some situations where iD should not suggest adding highway=crossing (#6508)
  • Avoid stale "connect endpoints" fix for "tags imply area" that could cause invalid areas (#6525)
  • Remove barrier=entrance deprecation (#6506)
  • Improve warning message when updating brand tags (#6443)
  • Improve checks for valid email and website values (#6494, thanks @SilentSpike)
  • Fix issue where crossings with kerb tags were treated primarily as kerbs (#6440)
  • Fix issue where upgrading office=administrative could also remove building=yes (#6466)
  • Fix issue where cuisine -> diet upgrades could overwrite existing values (#6462)

🐛 Bugfixes

  • Fix issue with deleting a member from a relation with a duplicate entity but different roles (#6504)
  • Fix issue where iD could crash upon save if user had edits stored before iD 2.15 (#6496)

🚀 Presets

  • Add presets for craft=signmaker, healthcare=counselling, shop=fashion_accessories
  • Remove unnecessary landuse=military added on military=bunker (#6509, #6518, thanks @matkoniecz)
  • Add Pipeline Valve preset (#6393)
  • Add Diameter field to Pipeline and Tree presets
  • Add additional terms for Mailbox preset (#6535)
  • Improve public bookcase preset (#6503, thanks @ToastHawaii)
  • Deprecate wifi=yes and wifi=free (#6524)
  • Lower match score for man_made/bridge preset
  • Add presets for Christian places of worship that do not use a cross icon or are not called churches (#6512)
  • Add preset for shop=military_surplus (#6470)
  • Deprecate various maxspeed mistags (#6478)
  • Add preset for office=bail_bond_agent and deprecate various mistags (#6472)
  • Deprecate "FIXME" -> "fixme", "NOTE" -> "note" (#6477)
  • Deprecate some "sustenance" tags
  • Change the label "Direction" to "Direction Affected" for vertex fields (#6469, thanks @BjornRasmussen)
  • Remove the search term "garage" from parking preset (#6455, thanks @BjornRasmussen)
  • Add preset for military=trench (#6474)
  • Add preset for leisure=escape_game (#6447)
  • Update Hackerspace fields

bhousel added some commits Jun 17, 2019

@tomhughes tomhughes merged commit 7fb85f1 into openstreetmap:master Jun 20, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 88.216%
Details
@mvl22

This comment has been minimized.

Copy link

commented Jun 23, 2019

Thank you for this - this is most welcome. Thank you also for your continued work on iD, which is much appreciated.

Would you please consider also reverting this change, which still remains problematic and not traditional practice:
openstreetmap/iD#5976
(Intersection without junction warning in save inappropriately also creates highway=crossing tag)

Obviously best to discuss that further there.

@tomhughes

This comment has been minimized.

Copy link
Member

commented Jun 23, 2019

Indeed it is best to discuss it there so I'm not sure why you are raising it here?

@mvl22

This comment has been minimized.

Copy link

commented Jun 23, 2019

Indeed it is best to discuss it there so I'm not sure why you are raising it here?

Because this is a thread about reversion, rather than the merits of the individual issues. There doesn't seem to be anywhere what that is discussed other than here and I specifically couldn't see a ticket - is there one?

@tomhughes

This comment has been minimized.

Copy link
Member

commented Jun 23, 2019

No this thread is just a PR asking me to merge the latest iD that happens to list the changes made in that version.

Currently we deploy iD as shipped by upstream so if you want to discuss what goes into iD then you will need to do it upstream.

If you're asking that we customise the version deployed on openstreetmap.org then that would be a valid discussion to have here, and there has been some talk about potentially needing to do it recently, but I don't think that currently a practical way for us to do it.

Practically speaking it would be a fork and would require considerable resources to maintain - in all probability somebody would need to volunteer to maintain a fork, do builds of that forks, and then open PRs here to have us deploy them as the upstream iD team currently does.

@mvl22

This comment has been minimized.

Copy link

commented Jun 23, 2019

If you're asking that we customise the version deployed on openstreetmap.org

Nope, definitely wasn't even considering that. I would strongly hope that OSM can continue to use the main iD branch, not least as iD ought to be in line with the values and expectations of the community.

if you want to discuss what goes into iD then you will need to do it upstream

OK, thanks. The PR here was started by an iD developer. Shame that an issue about that specifically hadn't been started, so a discussion about what could be included could have been had.

@bhousel bhousel deleted the osmlab:iD-2.15.2 branch Jun 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.