From 7e50f701b7d889719d501bbaa2c5625b03c28d35 Mon Sep 17 00:00:00 2001 From: pyrog Date: Fri, 8 Nov 2019 16:06:37 +0100 Subject: [PATCH 1/2] Update browse_tags_helper.rb Fix #2425 --- app/helpers/browse_tags_helper.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/helpers/browse_tags_helper.rb b/app/helpers/browse_tags_helper.rb index bbf6f3cf72..47767057c3 100644 --- a/app/helpers/browse_tags_helper.rb +++ b/app/helpers/browse_tags_helper.rb @@ -116,7 +116,7 @@ def wikidata_links(key, value) def wikimedia_commons_link(key, value) if key == "wikimedia_commons" && value =~ /^(?:file|category):/i return { - :url => "//commons.wikimedia.org/wiki/#{value}?uselang=#{I18n.locale}", + :url => "//commons.wikimedia.org/wiki/#{value}", :title => value } end From 20f9e044f481d23caa5cd9e10fa63c5e7d3784cc Mon Sep 17 00:00:00 2001 From: pyrog Date: Wed, 13 Nov 2019 13:07:23 +0100 Subject: [PATCH 2/2] Update tests --- test/helpers/browse_tags_helper_test.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/helpers/browse_tags_helper_test.rb b/test/helpers/browse_tags_helper_test.rb index a6390df38c..6bca0b1264 100644 --- a/test/helpers/browse_tags_helper_test.rb +++ b/test/helpers/browse_tags_helper_test.rb @@ -49,7 +49,7 @@ def test_format_value assert_dom_equal "Q123", html html = format_value("wikimedia_commons", "File:Test.jpg") - assert_dom_equal "File:Test.jpg", html + assert_dom_equal "File:Test.jpg", html html = format_value("colour", "#f00") assert_dom_equal %(#f00), html @@ -204,7 +204,7 @@ def test_wikimedia_commons_link assert_nil link link = wikimedia_commons_link("wikimedia_commons", "File:Test.jpg") - assert_equal "//commons.wikimedia.org/wiki/File:Test.jpg?uselang=en", link[:url] + assert_equal "//commons.wikimedia.org/wiki/File:Test.jpg", link[:url] assert_equal "File:Test.jpg", link[:title] link = wikimedia_commons_link("wikimedia_commons", "Category:Test_Category")