New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New note markers #253

Closed
wants to merge 53 commits into
base: master
from

Conversation

Projects
None yet
9 participants
@ponychicken
Contributor

ponychicken commented May 5, 2013

which fit the look of the other (leaflet) map markers. SVG source is included.
screen shot 2013-05-05 at 15 29 21

New note markers
which fit the look of the other map markers.
@tomhughes

This comment has been minimized.

Show comment
Hide comment
@tomhughes

tomhughes May 5, 2013

Member

What do people think? Do we prefer these markers?

Certainly if we go with these markers then a code change will be needed to make the anchor point of the marker at the bottom instead of in the middle like the current ones.

Member

tomhughes commented May 5, 2013

What do people think? Do we prefer these markers?

Certainly if we go with these markers then a code change will be needed to make the anchor point of the marker at the bottom instead of in the middle like the current ones.

@ingalls

This comment has been minimized.

Show comment
Hide comment
@ingalls

ingalls May 5, 2013

Contributor

+1

Contributor

ingalls commented May 5, 2013

+1

@tyrasd

This comment has been minimized.

Show comment
Hide comment
@tyrasd

tyrasd May 5, 2013

Member

+1

Member

tyrasd commented May 5, 2013

+1

@ppawel

This comment has been minimized.

Show comment
Hide comment
@ppawel

ppawel May 5, 2013

Contributor

+1

Contributor

ppawel commented May 5, 2013

+1

tmcw and others added some commits Apr 1, 2013

Add iD editor
iD sources live in vendor/assets/iD, and are managed with
vendorer, using the "rewrite" functionality to replace relative
paths in the CSS with <%= asset_path(…) %> directives.

To avoid needing to namespace all of its CSS classes, iD
is embedded via an iframe.

To setup, edit application.yml to include an `id_key` key.
(It can use the same consumer key as P2 if you like.)
Show object icons in the margin on data browers pages
Avoids indenting the text which looks odd, especially for things
which don't have an icon.
Fix browse view display issues in medium width windows
Floats are evil - using inline-block instead makes the whole thing
easier and more stable.

tomhughes and others added some commits May 8, 2013

Fix gap for iconless nodes in history view
Done by inlining icons via ::before and content: url(...) so that tag
combinations without an icon do not get any additional markup at all.
Fix link
Previous was pointing to a redirect.
@ponychicken

This comment has been minimized.

Show comment
Hide comment
@ponychicken

ponychicken May 12, 2013

Contributor

Damn, something went wrong here. Ignore all new commits but the last one

Contributor

ponychicken commented May 12, 2013

Damn, something went wrong here. Ignore all new commits but the last one

@tomhughes

This comment has been minimized.

Show comment
Hide comment
@tomhughes

tomhughes May 13, 2013

Member

I've merged this to http://tomh.apis.dev.openstreetmap.org/ so people can try it out.

Member

tomhughes commented May 13, 2013

I've merged this to http://tomh.apis.dev.openstreetmap.org/ so people can try it out.

@tmcw

This comment has been minimized.

Show comment
Hide comment
@tmcw

tmcw May 31, 2013

Contributor

These look great to me.

Contributor

tmcw commented May 31, 2013

These look great to me.

@tomhughes

This comment has been minimized.

Show comment
Hide comment
@tomhughes

tomhughes Jun 2, 2013

Member

Merged.

Member

tomhughes commented Jun 2, 2013

Merged.

@tomhughes tomhughes closed this Jun 2, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment