Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groups sketch #297

Closed
wants to merge 41 commits into from

Conversation

@tmcw
Copy link
Contributor

commented Jun 10, 2013

/cc @emacsen @samanpwbb @mvexel

This is not functional yet. I don't think this is a good use of sprint time since it's not day-doable.

  • Get the Model to actually work
  • Finish the form
tmcw and others added 8 commits Jun 10, 2013
Add the ability to creata a new group
This adds a new method to the groups_controller and
creates the database table for groups
Group memberships
Now users can be members in groups. Migration and model included here… but controller endpoints and tests are outstanding.
Adding a list all groups view to the group index
This provides a basic listing of all available groups
longer term this will need to look differently
@drewda

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2013

@tmcw, you can check off that first task now.

@Zverik

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2013

Are those public groups which all users can enter, or a user can create a private group and let only some people in?

@drewda

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2013

Just public groups for now.

Do you have a use for private groups?
On Jun 11, 2013 7:23 PM, "Ilya Zverev" notifications@github.com wrote:

Are those public groups which all users can enter, or a user can create a
private group and let only some people in?


Reply to this email directly or view it on GitHubhttps://github.com//pull/297#issuecomment-19303626
.

@Zverik

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2013

yes, groups of friends who'd like to monitor each other mapping.

Groups: controller and views in progress
I'll be returning to finish and polish.
@drewda

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2013

Good to know, @Zverik. I can keep that in mind for the future.

@drewda

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2013

Thanks for adding, @systemed. Please keep going if you have more time!

@mvexel

This comment has been minimized.

Copy link
Contributor

commented Sep 24, 2013

Note that there is a live instance of this at http://groups.apis.dev.openstreetmap.org - so please have a look and work with the functionality in place. You will have to log in and go to your profile page to see the Groups functionality exposed.

@tomhughes

This comment has been minimized.

Copy link
Member

commented Sep 24, 2013

A few obvious issues I've noticed, firstly, when you join a group you see:

screenshot from 2013-09-24 20 25 26

Which looks like there is a translation missing.

Then on the main group view we see:

screenshot from 2013-09-24 20 25 12

Which has a strange blank space above the list of members, and the title for the list of diary posts is displaced over to the right instead of being about the diary entry.

@tomhughes

This comment has been minimized.

Copy link
Member

commented Sep 24, 2013

Ah the blank space is where the description should be - we should probably require that groups have at least some minimal description text.

@iandees

This comment has been minimized.

Copy link
Contributor

commented Sep 24, 2013

...and that %{title} was my screwup when making a change earlier. Should be fixed in the most recent code.

@lxbarth

This comment has been minimized.

Copy link
Contributor

commented Sep 24, 2013

As the discussion is reviving here I've posted some thoughts on groups I wrote up right after Birmingham. Discussion too broad for this thread, but I wanted to link here as it's relevant: http://www.openstreetmap.org/user/lxbarth/diary/20060

@drewda

This comment has been minimized.

Copy link
Contributor

commented Sep 24, 2013

@tomhughes right now the description is required to be two characters in length: https://github.com/osmlab/openstreetmap-website/blame/378ad376b4e8049fb9787eb66346db933e7deede/app/models/group.rb#L18 That is, enough to make sure there's some text but not to ensure that it's meaningful or displayable.

@tyrasd

This comment has been minimized.

Copy link
Member

commented Sep 24, 2013

  1. I get the following error message (HTTP code 500) when joining/leaving groups:

    ActionController::RedirectBackError: No HTTP_REFERER was set in the request to this action, so redirect_to :back could not be called successfully. If this is a test, make sure to specify request.env["HTTP_REFERER"].
    

    My browser doesn't send Referer information, so that could be the cause here.

  2. The notification bar (e.g. "You have joined …") apparently doesn't escape html-code. Try joining this group: http://groups.apis.dev.openstreetmap.org/groups/5

@drewda

This comment has been minimized.

Copy link
Contributor

commented Sep 24, 2013

Good catch on Item 2, @tyrasd ;-)

@systemed

This comment has been minimized.

Copy link
Contributor

commented Sep 25, 2013

The main todo I was looking at was to get the diary entries properly paginated, but I got lost in a maze of twisty little views, all alike. If someone who actually knows what they're doing would like to fix that, that'd be excellent.

mikelmaron added 4 commits Jan 23, 2014
Merge branch 'master' into groups-sketch
Conflicts:
	app/assets/stylesheets/common.css.scss
	app/models/diary_entry.rb
	app/models/user.rb
	app/views/diary_entry/edit.html.erb
	app/views/layouts/_user_menu.html.erb
	config/environments/production.rb
	db/structure.sql

@openstreetmap-mirror openstreetmap-mirror force-pushed the openstreetmap:master branch from 068471f to d87ea68 Dec 19, 2014

@tmcw

This comment has been minimized.

Copy link
Contributor Author

commented May 11, 2015

I think we should close this. It's very stale and nobody's working on it.

@mikelmaron

This comment has been minimized.

Copy link
Contributor

commented May 11, 2015

yea, not active. would be good to pick this up again sometime, but not in my view near term. moabi made quite a lot of additions on groups in the mean time too.

@systemed

This comment has been minimized.

Copy link
Contributor

commented Jun 17, 2015

I'm still very keen to get this live, and we're pretty close. It'd be a huge boon to OSM.

I haven't been able to take it forward as a number of outstanding issues (notably the pagination) are beyond my rails-fu, though I've tried a couple of times. But with a bit of help I don't see why we couldn't get this live within the month.

@timwaters

This comment has been minimized.

Copy link

commented Jun 21, 2015

The moabi / crowdcover groups work I contributed to is at https://github.com/crowdcover/openstreetmap-website in the groups-sketch branch. The key difference is that groups have a lead, and are invite only, with invites occurring via the messaging / email system. Group diaries are included as well as a group picture, and the group map now makes sense. No group changeset / history view was developed however. (The Moabi system also has a fair bit of other stuff with groups, including custom iD presets etc)

@tmcw tmcw closed this Nov 3, 2015

@bhousel bhousel deleted the osmlab:groups-sketch branch Feb 6, 2017

@mikelmaron mikelmaron referenced this pull request Feb 2, 2018
@kiselev-dv

This comment has been minimized.

Copy link

commented May 1, 2019

Can somebody restore the branch? Want to get that functionality onto osm.org.

@tomhughes

This comment has been minimized.

Copy link
Member

commented May 1, 2019

As far as I know f034ac5 was the tip of the branch when it was deleted so if you can fetch that and create a local branch from it then that should work.

It's about five years old though so I suspect that it may be of minimal use...

@tomhughes

This comment has been minimized.

Copy link
Member

commented May 1, 2019

There are also some things (like something to do with editor presets) that don't seem to be anything to do with this branch so you might need to tidy up the history somewhat.

@openbrian openbrian restored the osmlab:groups-sketch branch Aug 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.