Introduce sidebar content get/set functions #3773
Conversation
|
|
||
| $("#sidebar_content").html(content.not("link[type=\"application/atom+xml\"]")); | ||
|
|
||
| OSM.setSidebarContent([xhr.getResponseHeader("X-Page-Title"), xhr.responseText]); |
There was a problem hiding this comment.
What's the idea between packing these arguments into an array and then unpacking them inside the function rather than just passing two arguments?
Is it so you can pass the array returned by the get function into the set function in a later patch?
There was a problem hiding this comment.
The idea is for the get function to be able to receive as an argument whatever was returned by the set function.
Get() needs to return two things. They need to be packed into something before being returned. Currently it's easy to imagine how you can unpack them and pass as individual arguments to set(). What if I add more things? What if I decide that with more things it's better to return an object from get()? I don't want to unpack such objects for set() arguments.
Part of c21b5ee.
OSM.getSidebarContent() is used in later commits of #3682 to store changeset lists.