Edit tab #43

Closed
wants to merge 17 commits into
from

Conversation

Projects
None yet
2 participants
Contributor

tmcw commented Apr 11, 2012

This changes the behavior of the editing tabs in three
places. Instead of the current hovering behavior, you
can click on the arrow and get the drop-down menu.
Any click outside that on the page will deactivate
the menu, following the UI paradigm of most desktop
environments. Also simplifies the javascript code
significantly.

tmcw added some commits Feb 14, 2012

@tmcw tmcw Add GPLv2 license file and mention in README 8dbd1cf
@tmcw tmcw Merge branch 'master' of https://github.com/openstreetmap/openstreetm… 397703c
@tmcw tmcw Merge branch 'master' of https://github.com/openstreetmap/openstreetm… 72b0722
@tmcw tmcw Merge branch 'master' of https://github.com/openstreetmap/openstreetm… 3f5ba94
@tmcw tmcw Merge branch 'master' of https://github.com/openstreetmap/openstreetm… feae8f2
@tmcw tmcw Merge branch 'master' of https://github.com/openstreetmap/openstreetm… a35053c
@tmcw tmcw Merge branch 'master' of https://github.com/openstreetmap/openstreetm… 8abf910
@tmcw tmcw Merge branch 'master' of https://github.com/openstreetmap/openstreetm… 19e75c2
@tmcw tmcw Merge branch 'master' of https://github.com/openstreetmap/openstreetm… 3e5cafc
@tmcw tmcw Merge branch 'master' of https://github.com/openstreetmap/openstreetm… 5316998
@tmcw tmcw Merge branch 'master' of https://github.com/openstreetmap/openstreetm… 5554885
@tmcw tmcw Merge branch 'master' of https://github.com/openstreetmap/openstreetm… 67471ef
@tmcw tmcw Merge branch 'master' of https://github.com/openstreetmap/openstreetm… 0573b88
@tmcw tmcw This changes the behavior of the editing tabs in three
places. Instead of the current hovering behavior, you
can click on the arrow and get the drop-down menu.
Any click outside that on the page will deactivate
the menu, following the UI paradigm of most desktop
environments. Also simplifies the javascript code
significantly.
9336dd4
@tmcw tmcw Remove delay parameter from createMenu, that is now deprecated 50e5257

@tomhughes tomhughes commented on an outdated diff Apr 11, 2012

app/assets/stylesheets/common.css.scss
@@ -366,23 +366,36 @@ h2 {
/* Rules for edit menu */
+.arrow {
+ margin-left: 10px;
+ padding: 5px;
+ border-left: 1px solid #eee;
+}
@tomhughes

tomhughes Apr 11, 2012

Owner

The margin-left and border-left bits of this will need to go in ltr.css with reversed versions in rtl.css.

Contributor

tmcw commented Apr 22, 2012

Any other modifications needed here?

Owner

tomhughes commented Apr 23, 2012

Merged and deployed.

tomhughes closed this Apr 23, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment