Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for embedding maps with [map][/map] format. #524

Closed
wants to merge 2 commits into from
Closed

Add support for embedding maps with [map][/map] format. #524

wants to merge 2 commits into from

Conversation

kiselev-dv
Copy link

In diary posts, comments, and previews sequence [map]some features here[/map] now will be converted into embedded maps. Also add builtin editor (link in markdown help).

See more about mapBB here http://mapbbcode.org/

@tomhughes
Copy link
Member

I really wish you had said something before you spent a lot of time on this...

My main issue with this is that the mapbbcode thing is brand new and we have no idea what sort of uptake it is going to have, and if we add support for it now then we are going to have to support it forever more, even if it doesn't get any sort of traction. I realise that's a somewhat circular argument, but it is a real issue from a maintenance point of view.

A second issue is the apparent inclusion of Bing map layers, which I think LWG will probably need to have a look at before we could consider it.

@tomhughes
Copy link
Member

BTW what is site#mapbbeditor for exactly? Only as far as I can see nothing actually uses it?

@kiselev-dv
Copy link
Author

Hi.

site#mapbbeditor - can be opened from markdown formatting hint. It will open visual editor.
It linked rather tricky mapBB editor open new window at /site/mapbbeditor and in routes it mapped onto site#mapbbeditor there is no direct linking in code, I'm not an expert in ruby, so I don't know is there better way for such things.

Bing map layer is optional, Bing.js was in original distribution of mapBB, so if it may cause license problems, It can be dropped out.

Google just dropped maps api v2 which was more more wider in use, so I think, if mapBB die, it wouldn't be a big disaster when users get [map]some data[/map] instead of embedded map.

@pnorman
Copy link
Contributor

pnorman commented Aug 16, 2016

Given that map bbcode really has no additional traction that I can see I recommend closing.

@tomhughes tomhughes closed this Aug 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants