New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore correct link behavior with modifier keys #599

Merged
merged 2 commits into from Dec 3, 2013

Conversation

Projects
None yet
3 participants
@jfirebaugh
Copy link
Member

jfirebaugh commented Dec 2, 2013

Fixes #562

@tomhughes

This comment has been minimized.

Copy link
Member

tomhughes commented Dec 2, 2013

This will work for most of the links, but not for the history list where clicks may be handled by the separate click handler in index/history.js.

@jfirebaugh

This comment has been minimized.

Copy link
Member

jfirebaugh commented Dec 2, 2013

Yeah I looked at that but I don't see any good way to fix it short of reimplementing browser-specific behavior.

@tomhughes

This comment has been minimized.

Copy link
Member

tomhughes commented Dec 2, 2013

Oh I see what you mean... We could ignore those clicks if the modifier was active though? It would mean that a ctrl click outside the link wouldn't do anything but would at least ensure that a ctrl click on the link opened a new tab/window.

Improve click behavior on changeset entries
On Chrome, this lets clicks with modifier keys anywhere
on the changeset entry work as expected. On other browsers,
modifier keys still only work on the link itself.
@jfirebaugh

This comment has been minimized.

Copy link
Member

jfirebaugh commented Dec 3, 2013

Found a way to make it work in Chrome, and work a bit better in other browsers.

@tomhughes

This comment has been minimized.

Copy link
Member

tomhughes commented Dec 3, 2013

If I'd known you were going to go that far I'd have recommended jquery.simulate ;-)

@openstreetmap-mirror openstreetmap-mirror merged commit 528d4a0 into openstreetmap:master Dec 3, 2013

@jfirebaugh jfirebaugh deleted the jfirebaugh:562 branch Dec 3, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment