Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable 2FA requirement for OpenStreetMap Github organisation #540

Closed
11 of 23 tasks
Firefishy opened this issue Jun 16, 2021 · 17 comments
Closed
11 of 23 tasks

Enable 2FA requirement for OpenStreetMap Github organisation #540

Firefishy opened this issue Jun 16, 2021 · 17 comments

Comments

@Firefishy
Copy link
Member

Firefishy commented Jun 16, 2021

We should enable the 2FA requirement for the OpenStreetMap Github organisation.

The following users need to enable 2FA on their account or will they will automatically be removed from https://github.com/openstreetmap when the 2FA requirement is enforced.

I propose 1st August 2021 as the deadline to enable 2FA.

@Firefishy Firefishy changed the title Enable 2FA requirement for OpenStreetMap on Github organisation Enable 2FA requirement for OpenStreetMap Github organisation Jun 16, 2021
@tomhughes
Copy link
Member

Being a member of the organisation doesn't actually mean much - many of the people with access to particular repositories are not organisation members because of the nature of the org as a mixture of projects.

@Firefishy
Copy link
Member Author

Being a member of the organisation doesn't actually mean much - many of the people with access to particular repositories are not organisation members because of the nature of the org as a mixture of projects.

The list is all users who have permission to any repo under the openstreetmap organisation, regardless of organisational membership.

@grischard
Copy link
Collaborator

One common objection will be that some of these are bot or shared accounts, like @josmmirror or @openstreetmap-mirror, or that it needs one particular phone.

You don't you need to link just one device, but can instead use the oathtool cli tool. The "secret" is a long string which the QR code contains.

> oathtool --tot -b eiLiN4oafohfaof2
053648

@Firefishy
Copy link
Member Author

Firefishy commented Jun 16, 2021

One common objection will be that some of these are bot or shared accounts, like @josmmirror or @openstreetmap-mirror, or that it needs one particular phone.

If using automation, use git over ssh with an ssh key or use a personal access token if you need github API access, both of which do not require a 2FA login tokens.

@Krakonos
Copy link
Member

Enabled.

1 similar comment
@pantierra
Copy link

Enabled.

@lectrician1
Copy link

Enabled

1 similar comment
@simonpoole
Copy link

Enabled

@Firefishy
Copy link
Member Author

15 to go...

@ChristineKarch
Copy link

ChristineKarch commented Jun 21, 2021 via email

@Firefishy
Copy link
Member Author

Firefishy commented Jun 27, 2021

@scrosby @bastik @podolsir @openstreetmap-mirror @stoecker @LambertusIJsselstein @frafra @marcu @mcauer @tatsvc @Nakaner @rabidllama @josmmirror Please enable 2FA on your accounts when you have a chance.

Why force 2FA? We have some critical project repos under the https://github.com/openstreetmap/ project, 2FA can only be enforced at the top project level. 2FA gives us another important layer of protection against account compromise.

@Firefishy
Copy link
Member Author

@scrosby @bastik @podolsir @openstreetmap-mirror @stoecker @LambertusIJsselstein @frafra @marcu @mcauer @tatsvc @Nakaner @rabidllama @josmmirror Reminder, please enable 2FA on your Github accounts, alternatively let us know if you are ok being removed from the https://github.com/openstreetmap/ github project. Happy to help if needed.

@marcu
Copy link

marcu commented Jul 19, 2021

Done !

@grischard
Copy link
Collaborator

JOSM ticket for this: https://josm.openstreetmap.de/ticket/21128

@Firefishy
Copy link
Member Author

@scrosby @bastik @podolsir @openstreetmap-mirror @stoecker @LambertusIJsselstein @frafra @mcauer @tatsvc @Nakaner @rabidllama @josmmirror This is important...

I am the bully enabling the 2FA on the @openstreetmap github project. Other projects have had accounts compromised and exploit commits snuck in. Applying security after a compromise is too late.

Enabling 2FA on an account should not disrupt git actions in any way [1].
The 2FA is only required when login into github UI or API. If the account needs access to the Github API, it should be using a Github Personal access token, which is separate and unaffected by 2FA.

Github supports saving a backup 2FA recovery key offline (e.g: print-out). It also supports using a SMS as a backup recovery method, if desired.

The 2FA tokens are generated from a shared secret which can be decoded from the QR code from setup stage. I normally save a copy of the QR photo.

I used oathtool --totp -b *SECRET* on the command line. Share the secret with others if they also need 2FA codes, as per how you do with a shared account password.

1: As long as you are using SSH key for authentication in git, which you should be using.

@Nakaner
Copy link

Nakaner commented Jul 31, 2021

Done. It can be considered state of the art to use two-factor auth but I was just too lazy to add it to my account so far.

@Firefishy
Copy link
Member Author

I have now enforced 2FA on the @openstreetmap organisation.

The following users have been automatically removed because they do not currently have 2FA enabled on their accounts:
@scrosby @bastik @podolsir @openstreetmap-mirror @stoecker @LambertusIJsselstein @frafra @mcauer @tatsvc @rabidllama @josmmirror

Happy to add back any of the users above once 2FA has been enabled on their account. Message me or email operations "AT" osmfoundation "DOT" org

@openstreetmap openstreetmap deleted a comment from Sopo44 Apr 2, 2022
@openstreetmap openstreetmap deleted a comment from Sopo44 Apr 2, 2022
@openstreetmap openstreetmap locked as spam and limited conversation to collaborators Apr 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants