Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider blocking /dirty on the tile CDN #681

Closed
pnorman opened this issue Jul 14, 2022 · 2 comments
Closed

Consider blocking /dirty on the tile CDN #681

pnorman opened this issue Jul 14, 2022 · 2 comments
Assignees
Labels
service:tiles The raster map on tile.openstreetmap.org

Comments

@pnorman
Copy link
Collaborator

pnorman commented Jul 14, 2022

Users have oudated expectations of what requesting https://tile.openstreetmap.org/z/x/y.png/dirty does, based on when there was one render server. Their expectation is that if the request a tile, see it is outdated, append /dirty, and everyone will get an updated version of the tile. When we had one render server, this was accurate, if they refreshed the correct way.

This has not been what happens for about a decade. What currently happens is a user requests a tile, it gets a tile from a load-balanced set of render servers, with different sets of servers depending on cache location, zoom, and (x/8)%2. This means that the user has, depending on region, a

  • 50% chance of sending the dirty command to a different server than they were viewing the tile from
  • 50% chance of reloading and getting a different server than they issued the dirty command to
  • 0% chance of fixing what they were trying to fix for all users

I do not believe it is ever sensible to issue the /dirty command to the CDN. Instead, if a user understands the internals of OSMF infrastructure, they need to issue it against the relevant backends.

The same applies to /status. Fetching a tile through the CDN and then fetching its /status does not guarantee the status page will be the status for the tile that was just viewed.

@pnorman pnorman added the service:tiles The raster map on tile.openstreetmap.org label Jul 14, 2022
@pnorman pnorman self-assigned this Jul 14, 2022
@pnorman
Copy link
Collaborator Author

pnorman commented Jul 16, 2022

Implemented.

@lgommans
Copy link

Instead, if a user understands the internals of OSMF infrastructure, they need to issue it against the relevant backends.

Which backends are relevant and what would one issue against them?

Marking a tile dirty always worked for me, was a bit sad to notice today that I couldn't make before/after screenshots on demand anymore. (The assumption made above, stating what "the user" assumes, is incorrect.) In today's case, the tiles refreshed on their own a few minutes later so I ended up being able to make my screenshot, but I am curious how one is supposed to do this now.

To also help others, perhaps the /dirty page could mention what one should do instead. Current behavior is loading for a long time and then showing "invalid tile request".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service:tiles The raster map on tile.openstreetmap.org
Projects
None yet
Development

No branches or pull requests

2 participants