Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove '--unlogged' option #940

Closed
lonvia opened this issue Aug 6, 2019 · 1 comment
Closed

Remove '--unlogged' option #940

lonvia opened this issue Aug 6, 2019 · 1 comment

Comments

@lonvia
Copy link
Collaborator

@lonvia lonvia commented Aug 6, 2019

The --unlogged option currently only has an effect on middle tables. Data tables are always unlogged first and full tables after copying. That's likely not what people expect when they use it. We could change the behaviour to also make the final data tables unlogged. However, given that the option is pretty dangerous (and we have too many command line options anyway), I'd rather see it removed completely. Instead we should just set middle tables automatically to unlogged when --drop is enabled.

@pnorman

This comment has been minimized.

Copy link
Collaborator

@pnorman pnorman commented Aug 6, 2019

That's likely not what people expect when they use it. We could change the behaviour to also make the final data tables unlogged. However, given that the option is pretty dangerous (and we have too many command line options anyway), I'd rather see it removed completely.

👍

@lonvia lonvia mentioned this issue Aug 7, 2019
@lonvia lonvia closed this in 9fa1061 Aug 10, 2019
gplv2 added a commit to gplv2/grb-postgis that referenced this issue Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.